Conduit Probe does not copy "Round Robin" or "Self Feed" settings #1105
Labels
No labels
Area-Assets
Area-Backend
Area-Conduits
Area-Datapacks
Area-Lang
Area-Mod Compat
Area-Parity
Area-Rendering
Good first issue
MC-1.19.2
MC-1.20.1
MC-1.20.4
MC-1.20.6
MC-1.21
MC-1.21.1
Modtoberfest
P-0-High
P-1-Medium
P-2-Low
Status-Awaiting Response
Status-Behind-Flag
Status-Blocked
Status-Cannot Reproduce
Status-Duplicate
Status-Help Wanted
Status-Incomplete Report
Status-Invalid
Status-Needs LTS Backport
Status-Needs Updating
Status-Stale
Status-To Implement
Status-Triage
Status-Wontfix
Status-Wontmerge
Type-Backport
Type-Bug
Type-Documentation
Type-Enhancement
Type-Question
Type-RFC
Type-Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Team-EnderIO/EnderIO#1105
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Is there an existing issue for this?
Current Behavior
When using the Conduit Probe to copy/paste Item Conduit settings, the "Round Robin" or "Self Feed" settings are not copied over as well.
Expected Behavior
Conduit Probe copy/paste mode should copy over all conduit settings.
How to Test
Create a new world.
Set up two pairs of Item Conduits connected to Chests.
Use the Conduit Probe in Copy/Paste mode to copy the settings over to the other conduit.
Nothing changes.
Local Environment
Any Additional Information?
No response
I regret to say that we no longer officially support Minecraft 1.20.1 - as such we will not be officially fixing this issue.
If any community member wishes to submit a pull request to address this issue, feel free to open a PR and we will review and merge it.
I will close outstanding 1.20.1 issues in a little while, to keep the issue list clear.
Thanks again for your report.
Round-robin and self-feed are currently not saved in conduit probe settings because they're saved in ItemConduitData as item conduit-specific parameters instead of DynamicConnectionState, where all the other conduit settings are.
I would like to work on this issue, but seeing that @Rover656 mentioned that priority and round robin (and probably self-feed?) should stay in ItemConduitData, maybe I shouldn't refactor DynamicConnectionState and instead grab data directly from ItemConduitData through bundle.getNodeFor()?
Fixed by #1124