Conduit Probe does not copy "Round Robin" or "Self Feed" settings #1105

Closed
opened 2025-07-03 22:59:45 +00:00 by Xefyr0 · 3 comments
Xefyr0 commented 2025-07-03 22:59:45 +00:00 (Migrated from github.com)

Is there an existing issue for this?

  • I did not find any existing issues.

Current Behavior

When using the Conduit Probe to copy/paste Item Conduit settings, the "Round Robin" or "Self Feed" settings are not copied over as well.

Expected Behavior

Conduit Probe copy/paste mode should copy over all conduit settings.

How to Test

  1. Create a new world.

  2. Set up two pairs of Item Conduits connected to Chests.

Image

  1. Set one conduit to have both "Round Robin" or "Self Feed" enabled.

Image

  1. Use the Conduit Probe in Copy/Paste mode to copy the settings over to the other conduit.

  2. Nothing changes.

Image

Local Environment

- **Operating System**: Windows 10
- **Java version**: Oracle JDK-17.0.12
- **Minecraft Version**: 1.20.1 
- **Version**: 6.2.11-beta
- **Other Mods**: EMI and JEI

Any Additional Information?

No response

### Is there an existing issue for this? - [x] I did not find any existing issues. ### Current Behavior When using the Conduit Probe to copy/paste Item Conduit settings, the "Round Robin" or "Self Feed" settings are not copied over as well. ### Expected Behavior Conduit Probe copy/paste mode should copy over *all* conduit settings. ### How to Test 1. Create a new world. 2. Set up two pairs of Item Conduits connected to Chests. ![Image](https://github.com/user-attachments/assets/d6398224-d3b3-4289-94e9-1fa7f397df6d) 3. Set one conduit to have both "Round Robin" or "Self Feed" enabled. ![Image](https://github.com/user-attachments/assets/3bd2db96-79b8-425a-9b0f-404e855cd8d6) 4. Use the Conduit Probe in Copy/Paste mode to copy the settings over to the other conduit. 5. Nothing changes. ![Image](https://github.com/user-attachments/assets/fbdd6d22-55e7-4d04-87b1-d4b007e8f098) ### Local Environment ```markdown - **Operating System**: Windows 10 - **Java version**: Oracle JDK-17.0.12 - **Minecraft Version**: 1.20.1 - **Version**: 6.2.11-beta - **Other Mods**: EMI and JEI ``` ### Any Additional Information? _No response_
Rover656 commented 2025-07-12 21:08:51 +00:00 (Migrated from github.com)

I regret to say that we no longer officially support Minecraft 1.20.1 - as such we will not be officially fixing this issue.

If any community member wishes to submit a pull request to address this issue, feel free to open a PR and we will review and merge it.

I will close outstanding 1.20.1 issues in a little while, to keep the issue list clear.

Thanks again for your report.

I regret to say that we no longer officially support Minecraft 1.20.1 - as such we will not be officially fixing this issue. If any community member wishes to submit a pull request to address this issue, feel free to open a PR and we will review and merge it. I will close outstanding 1.20.1 issues in a little while, to keep the issue list clear. Thanks again for your report.
mosesyu1028 commented 2025-08-26 04:24:31 +00:00 (Migrated from github.com)

Round-robin and self-feed are currently not saved in conduit probe settings because they're saved in ItemConduitData as item conduit-specific parameters instead of DynamicConnectionState, where all the other conduit settings are.

I would like to work on this issue, but seeing that @Rover656 mentioned that priority and round robin (and probably self-feed?) should stay in ItemConduitData, maybe I shouldn't refactor DynamicConnectionState and instead grab data directly from ItemConduitData through bundle.getNodeFor()?

Round-robin and self-feed are currently not saved in conduit probe settings because they're saved in ItemConduitData as item conduit-specific parameters instead of DynamicConnectionState, where all the other conduit settings are. I would like to work on this issue, but seeing that @Rover656 [mentioned](https://github.com/Team-EnderIO/EnderIO/issues/588#issuecomment-2717565274) that priority and round robin (and probably self-feed?) should stay in ItemConduitData, maybe I shouldn't refactor DynamicConnectionState and instead grab data directly from ItemConduitData through bundle.getNodeFor()?
Rover656 commented 2025-08-28 17:45:51 +00:00 (Migrated from github.com)

Fixed by #1124

Fixed by #1124
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#1105
No description provided.