Team-EnderIO/EnderIO
1
0
Fork 0
Code Issues 114 Pull requests 13 Projects Releases 79 Packages Wiki Activity Actions

Improved fluid tanks. #111

Closed
albinaask wants to merge 0 commits from machine-fluid-tank-update-branch into dev/1.19.x
pull from: machine-fluid-tank-update-branch
merge into: Team-EnderIO:dev/1.19.x
Conversation 48 Commits - Files changed -
albinaask commented 2023-03-08 16:42:02 +00:00 (Migrated from github.com)
Copy link

Description

Fluid tanks now behave more like they behaved in 1.12, They can be clicked on with buckets or other containers to transfer fluid, their item correspondence are now correctly fluid containing items with accessible fluid stacks. The item variant now renders fluid and displays tank content on the extended tooltip which you can access by holding shift.

NOTE: should be merged after the #110 yeta wrench updates since it needs some of the stuff from that commit.

Todo. I think it is ready to merge, and then this could be worked on after an alpha release.

  • Fix the break particles of the tanks, I tried but didn't get this to work.
  • Allow tanks to stack to 64. I worked on this for like 12h, but only went around in circles. It seems to be rather involved.

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
# Description Fluid tanks now behave more like they behaved in 1.12, They can be clicked on with buckets or other containers to transfer fluid, their item correspondence are now correctly fluid containing items with accessible fluid stacks. The item variant now renders fluid and displays tank content on the extended tooltip which you can access by holding shift. NOTE: should be merged after the #110 yeta wrench updates since it needs some of the stuff from that commit. # Todo. I think it is ready to merge, and then this could be worked on after an alpha release. - [x] Fix the break particles of the tanks, I tried but didn't get this to work. - [ ] Allow tanks to stack to 64. I worked on this for like 12h, but only went around in circles. It seems to be rather involved. # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation
justliliandev (Migrated from github.com) requested changes 2023-03-09 21:37:08 +00:00
src/machines/java/com/enderio/machines/common/blockentity/base/MachineBlockEntity.java
justliliandev (Migrated from github.com) commented 2023-03-09 20:19:12 +00:00
Copy link

don't use notnull annotation add the package.info file that contains the default

don't use notnull annotation add the package.info file that contains the default
src/machines/java/com/enderio/machines/common/blockentity/base/MachineBlockEntity.java
justliliandev (Migrated from github.com) commented 2023-03-09 20:20:48 +00:00
Copy link

don't put this on one line

don't put this on one line
src/machines/java/com/enderio/machines/common/blockentity/base/MachineBlockEntity.java
justliliandev (Migrated from github.com) commented 2023-03-09 20:25:01 +00:00
Copy link

use UseOnly annotation for this

use UseOnly annotation for this
justliliandev (Migrated from github.com) commented 2023-03-09 20:26:04 +00:00
Copy link
        if (player != null && level != null && player.isSecondaryUseActive()) {//aka break block
```suggestion if (player != null && level != null && player.isSecondaryUseActive()) {//aka break block ```
justliliandev (Migrated from github.com) commented 2023-03-09 20:26:25 +00:00
Copy link

use pos from blockentity

use pos from blockentity
justliliandev (Migrated from github.com) commented 2023-03-09 20:26:38 +00:00
Copy link

use statehelper from blockentity

use statehelper from blockentity
justliliandev (Migrated from github.com) commented 2023-03-09 20:27:28 +00:00
Copy link

don't do blindcast, do instanceof check at the top if and remove comment

don't do blindcast, do instanceof check at the top if and remove comment
justliliandev (Migrated from github.com) commented 2023-03-09 20:32:24 +00:00
Copy link

add a helper for this, there might be more callers (and maybe throw from the player like the SoulVial, so yeah, add that to the helper as well)

add a helper for this, there might be more callers (and maybe throw from the player like the SoulVial, so yeah, add that to the helper as well)
justliliandev (Migrated from github.com) commented 2023-03-09 20:33:33 +00:00
Copy link
        } else {
```suggestion } else { ```
src/machines/java/com/enderio/machines/common/init/MachineBlocks.java
justliliandev (Migrated from github.com) commented 2023-03-09 20:40:21 +00:00
Copy link

merge those lines

merge those lines
src/machines/java/com/enderio/machines/common/init/MachineBlocks.java
justliliandev (Migrated from github.com) commented 2023-03-09 20:44:47 +00:00
Copy link
        Supplier<BlockEntityEntry<? extends MachineBlockEntity>> blockEntityEntry) {
```suggestion Supplier<BlockEntityEntry<? extends MachineBlockEntity>> blockEntityEntry) { ```
src/machines/java/com/enderio/machines/common/io/fluid/MachineFluidTank.java
justliliandev (Migrated from github.com) commented 2023-03-09 20:48:11 +00:00
Copy link

put text on new line

put text on new line
justliliandev (Migrated from github.com) commented 2023-03-09 20:48:31 +00:00
Copy link

put text on new line

put text on new line
justliliandev (Migrated from github.com) commented 2023-03-09 20:51:03 +00:00
Copy link

put text on new line

put text on new line
justliliandev (Migrated from github.com) commented 2023-03-09 21:00:18 +00:00
Copy link

use pattern like this:

if (source.isEmpty)
    return 0;
if (!fluid.isEmpty() && !fluid.isFluidEqual(source))
    return 0;
use pattern like this: ``` if (source.isEmpty) return 0; if (!fluid.isEmpty() && !fluid.isFluidEqual(source)) return 0; ```
justliliandev (Migrated from github.com) commented 2023-03-09 21:00:45 +00:00
Copy link
        if (fluid.isEmpty()) {
```suggestion if (fluid.isEmpty()) { ```
justliliandev (Migrated from github.com) commented 2023-03-09 21:01:02 +00:00
Copy link
        return fill(new FluidStack(fluid.getFluid(),desiredAmount), action, force);
```suggestion return fill(new FluidStack(fluid.getFluid(),desiredAmount), action, force); ```
justliliandev (Migrated from github.com) commented 2023-03-09 21:01:16 +00:00
Copy link
        return fill(source, action, false);
```suggestion return fill(source, action, false); ```
justliliandev (Migrated from github.com) commented 2023-03-09 21:04:05 +00:00
Copy link

use pattern from above and please put a space between if and whitespace

use pattern from above and please put a space between if and whitespace
justliliandev (Migrated from github.com) commented 2023-03-09 21:05:02 +00:00
Copy link

put return on new line and don't use else as it's the only other path as it return early

put return on new line and don't use else as it's the only other path as it return early
justliliandev (Migrated from github.com) commented 2023-03-09 21:05:23 +00:00
Copy link

don't use else

don't use else
justliliandev (Migrated from github.com) commented 2023-03-09 21:11:46 +00:00
Copy link

text on new line

text on new line
justliliandev (Migrated from github.com) commented 2023-03-09 21:12:05 +00:00
Copy link
        if (!player.level.isClientSide() && player.hasItemInSlot(EquipmentSlot.MAINHAND) && hand == InteractionHand.MAIN_HAND) {
```suggestion if (!player.level.isClientSide() && player.hasItemInSlot(EquipmentSlot.MAINHAND) && hand == InteractionHand.MAIN_HAND) { ```
justliliandev (Migrated from github.com) commented 2023-03-09 21:12:53 +00:00
Copy link

fix spaces for other conditions as well

fix spaces for other conditions as well
src/machines/java/com/enderio/machines/common/item/FluidTankItem.java
justliliandev (Migrated from github.com) commented 2023-03-09 21:15:42 +00:00
Copy link

you can't fix stackable fluid containers, like just don't. dupe bugs everywhere because there is no common way to do this

you can't fix stackable fluid containers, like just don't. dupe bugs everywhere because there is no common way to do this
src/machines/java/com/enderio/machines/common/item/FluidTankItem.java
justliliandev (Migrated from github.com) commented 2023-03-09 21:16:35 +00:00
Copy link

not necessarily, just do the ifPresent thing and log warning

not necessarily, just do the ifPresent thing and log warning
justliliandev (Migrated from github.com) commented 2023-03-09 21:22:14 +00:00
Copy link

nullable on line above

nullable on line above
justliliandev (Migrated from github.com) commented 2023-03-09 21:27:41 +00:00
Copy link

maybe use multiple Optional.map chains or fix the early returns like above

maybe use multiple Optional.map chains or fix the early returns like above
justliliandev (Migrated from github.com) commented 2023-03-09 21:27:57 +00:00
Copy link
        }
        
        protected void setFluid(FluidStack fluid) {
```suggestion } protected void setFluid(FluidStack fluid) { ```
justliliandev (Migrated from github.com) commented 2023-03-09 21:29:17 +00:00
Copy link

use ItemStack#getOrCreateTag

use ItemStack#getOrCreateTag
justliliandev (Migrated from github.com) commented 2023-03-09 21:31:05 +00:00
Copy link

follow java naming scheme beTag

follow java naming scheme beTag
src/main/java/com/enderio/base/common/blockentity/IWrenchable.java
justliliandev (Migrated from github.com) commented 2023-03-09 21:35:02 +00:00
Copy link

why does this extend IForgeBlockEntity?

why does this extend IForgeBlockEntity?
src/main/java/com/enderio/base/common/item/tool/YetaWrenchItem.java
justliliandev (Migrated from github.com) commented 2023-03-09 21:35:27 +00:00
Copy link

put return on new line and remove else

put return on new line and remove else
justliliandev (Migrated from github.com) commented 2023-03-09 21:36:10 +00:00
Copy link

don't use else here and call super

don't use else here and call super
albinaask (Migrated from github.com) reviewed 2023-03-16 15:42:36 +00:00
src/machines/java/com/enderio/machines/common/blockentity/base/MachineBlockEntity.java
albinaask (Migrated from github.com) commented 2023-03-16 15:42:35 +00:00
Copy link

Sorry, but I'm not really sure I understand what you mean since my understanding of the annotation system isn't good enough. Do you mean that I should remove the "@NotNull"? The reason that I inserted it was that befor I had it Intellij threw a warning at me saying that "Not annotated method overrides method annotated with @NotNull". It seems to be done that same way in the class "XPVacuumBlockEntity" line 88 in the method "getCapability". What's the difference between the two cases so I understand for next time?

Sorry, but I'm not really sure I understand what you mean since my understanding of the annotation system isn't good enough. Do you mean that I should remove the "@NotNull"? The reason that I inserted it was that befor I had it Intellij threw a warning at me saying that "Not annotated method overrides method annotated with @NotNull". It seems to be done that same way in the class "XPVacuumBlockEntity" line 88 in the method "getCapability". What's the difference between the two cases so I understand for next time?
albinaask (Migrated from github.com) reviewed 2023-03-16 15:45:56 +00:00
src/machines/java/com/enderio/machines/common/blockentity/base/MachineBlockEntity.java
albinaask (Migrated from github.com) commented 2023-03-16 15:45:56 +00:00
Copy link

I'll change it. But I'm wondering; since this is done in loads of other places in the code, even in the same class since before. What is the rule for when to do it and when not to?

I'll change it. But I'm wondering; since this is done in loads of other places in the code, even in the same class since before. What is the rule for when to do it and when not to?
albinaask (Migrated from github.com) reviewed 2023-03-16 15:48:18 +00:00
src/machines/java/com/enderio/machines/common/blockentity/base/MachineBlockEntity.java
albinaask (Migrated from github.com) commented 2023-03-16 15:48:17 +00:00
Copy link

Of course, just me not being used to the code base

Of course, just me not being used to the code base
justliliandev (Migrated from github.com) reviewed 2023-03-16 16:10:52 +00:00
src/machines/java/com/enderio/machines/common/blockentity/base/MachineBlockEntity.java
justliliandev (Migrated from github.com) commented 2023-03-16 16:10:51 +00:00
Copy link

basically: this doesn't happen in the code base (maybe one or two if they were missed). Some IDEs collapse one liner methods, but there are no methods that have the return in one line.
Only exception if the method does nothing and returns nothing, only then void method() {} is allowed on one line

basically: this doesn't happen in the code base (maybe one or two if they were missed). Some IDEs collapse one liner methods, but there are no methods that have the return in one line. Only exception if the method does nothing and returns nothing, only then `void method() {}` is allowed on one line
albinaask (Migrated from github.com) reviewed 2023-03-16 16:20:44 +00:00
src/machines/java/com/enderio/machines/common/init/MachineBlocks.java
albinaask (Migrated from github.com) commented 2023-03-16 16:20:44 +00:00
Copy link

Those lines were accidentally pushed since they should be part of the vat. I have now moved them to that branch.

Those lines were accidentally pushed since they should be part of the vat. I have now moved them to that branch.
albinaask (Migrated from github.com) reviewed 2023-03-16 16:22:37 +00:00
src/machines/java/com/enderio/machines/common/init/MachineBlocks.java
albinaask (Migrated from github.com) commented 2023-03-16 16:22:37 +00:00
Copy link

Done!

Done!
albinaask (Migrated from github.com) reviewed 2023-03-16 16:27:25 +00:00
src/machines/java/com/enderio/machines/common/io/fluid/MachineFluidTank.java
albinaask (Migrated from github.com) commented 2023-03-16 16:27:25 +00:00
Copy link

That pattern produces more branches that the branch predictor needs to navigate if the Java interpreter does not squash those into one. But it may be a price worth paying since it makes things clearer. I'll make the suggested change.

That pattern produces more branches that the branch predictor needs to navigate if the Java interpreter does not squash those into one. But it may be a price worth paying since it makes things clearer. I'll make the suggested change.
albinaask (Migrated from github.com) reviewed 2023-03-16 16:37:45 +00:00
src/machines/java/com/enderio/machines/common/item/FluidTankItem.java
albinaask (Migrated from github.com) commented 2023-03-16 16:37:44 +00:00
Copy link

What I meant was that the EnderIO fluidtanks in 1.12 were stackable, and the current implementation only supports fluidtanks that doesn't stack because of the code in [FluidTankEntity].internalDrain/fill. The same bug will be apparent for fluid cells from forestry for example. But I'll move this comment to those methods.

What I meant was that the EnderIO fluidtanks in 1.12 were stackable, and the current implementation only supports fluidtanks that doesn't stack because of the code in [FluidTankEntity].internalDrain/fill. The same bug will be apparent for fluid cells from forestry for example. But I'll move this comment to those methods.
albinaask (Migrated from github.com) reviewed 2023-03-16 16:46:40 +00:00
src/machines/java/com/enderio/machines/common/item/FluidTankItem.java
albinaask (Migrated from github.com) commented 2023-03-16 16:46:40 +00:00
Copy link

Or this was maybe what you meant? That we can't make them stack anymore?

Or this was maybe what you meant? That we can't make them stack anymore?
albinaask (Migrated from github.com) reviewed 2023-03-16 16:48:23 +00:00
src/machines/java/com/enderio/machines/common/item/FluidTankItem.java
albinaask (Migrated from github.com) commented 2023-03-16 16:48:23 +00:00
Copy link

Done

Done
albinaask (Migrated from github.com) reviewed 2023-03-16 16:51:33 +00:00
src/machines/java/com/enderio/machines/common/item/FluidTankItem.java
albinaask (Migrated from github.com) commented 2023-03-16 16:51:32 +00:00
Copy link

Done

Done
albinaask (Migrated from github.com) reviewed 2023-03-16 17:20:15 +00:00
src/machines/java/com/enderio/machines/common/item/FluidTankItem.java
albinaask (Migrated from github.com) commented 2023-03-16 17:20:14 +00:00
Copy link

Okay, so I don't understand how to do it, but chatGPT did apparently, so done now...

Okay, so I don't understand how to do it, but chatGPT did apparently, so done now...
albinaask (Migrated from github.com) reviewed 2023-03-16 17:20:50 +00:00
src/machines/java/com/enderio/machines/common/item/FluidTankItem.java
albinaask (Migrated from github.com) commented 2023-03-16 17:20:49 +00:00
Copy link

Done!

Done!
albinaask (Migrated from github.com) reviewed 2023-03-16 17:21:27 +00:00
src/machines/java/com/enderio/machines/common/item/FluidTankItem.java
albinaask (Migrated from github.com) commented 2023-03-16 17:21:26 +00:00
Copy link

Done!

Done!
albinaask (Migrated from github.com) reviewed 2023-03-16 17:21:36 +00:00
src/machines/java/com/enderio/machines/common/item/FluidTankItem.java
albinaask (Migrated from github.com) commented 2023-03-16 17:21:36 +00:00
Copy link

Done!

Done!
albinaask (Migrated from github.com) reviewed 2023-03-16 17:23:25 +00:00
src/main/java/com/enderio/base/common/blockentity/IWrenchable.java
albinaask (Migrated from github.com) commented 2023-03-16 17:23:25 +00:00
Copy link

I think I used a method in a block entity related class at some point during one of the many iterations while trying to get everything to work. Probably mostly legacy, but pretty useful for indicating that you only should be able to use the wrench in the configuration other than wrenching on block entities and that was the most suitable interface that BlockEntity was implementing. But I could absolutely change this! Would you rather it extending nothing?

I think I used a method in a block entity related class at some point during one of the many iterations while trying to get everything to work. Probably mostly legacy, but pretty useful for indicating that you only should be able to use the wrench in the configuration other than wrenching on block entities and that was the most suitable interface that BlockEntity was implementing. But I could absolutely change this! Would you rather it extending nothing?
albinaask (Migrated from github.com) reviewed 2023-03-16 17:25:20 +00:00
src/main/java/com/enderio/base/common/item/tool/YetaWrenchItem.java
albinaask (Migrated from github.com) commented 2023-03-16 17:25:19 +00:00
Copy link

This is a valid point, yet something that really is regarding #110 since that should be merged first anyway. But I'll definitely change it!

This is a valid point, yet something that really is regarding #110 since that should be merged first anyway. But I'll definitely change it!
albinaask (Migrated from github.com) reviewed 2023-03-16 17:25:59 +00:00
src/main/java/com/enderio/base/common/item/tool/YetaWrenchItem.java
albinaask (Migrated from github.com) commented 2023-03-16 17:25:58 +00:00
Copy link

Like above, but will fix also!

Like above, but will fix also!
albinaask (Migrated from github.com) reviewed 2023-03-16 17:28:34 +00:00
src/machines/java/com/enderio/machines/common/blockentity/base/MachineBlockEntity.java
albinaask (Migrated from github.com) commented 2023-03-16 17:28:33 +00:00
Copy link

Sure, added it in a class called PlayerInteractionUtil in the core source folder since I didn't find any other good place for it. If you have another place in mind, let me know!

Sure, added it in a class called PlayerInteractionUtil in the core source folder since I didn't find any other good place for it. If you have another place in mind, let me know!
albinaask commented 2023-03-16 17:32:03 +00:00 (Migrated from github.com)
Copy link

I've amended the commit. So now you should (hopefully) be able to see them.

I've amended the commit. So now you should (hopefully) be able to see them.
justliliandev (Migrated from github.com) reviewed 2023-03-16 18:40:27 +00:00
src/machines/java/com/enderio/machines/common/blockentity/base/MachineBlockEntity.java
justliliandev (Migrated from github.com) commented 2023-03-16 18:40:26 +00:00
Copy link

it is not wanted there either.
this file has the annotations for a whole package and that replaces the annotations on each field
https://github.com/SleepyTrousers/EnderIO-Rewrite/blob/dev/1.19.x/src/main/java/com/enderio/package-info.java

it is not wanted there either. this file has the annotations for a whole package and that replaces the annotations on each field <https://github.com/SleepyTrousers/EnderIO-Rewrite/blob/dev/1.19.x/src/main/java/com/enderio/package-info.java>
justliliandev (Migrated from github.com) reviewed 2023-03-16 18:54:21 +00:00
src/machines/java/com/enderio/machines/common/io/fluid/MachineFluidTank.java
justliliandev (Migrated from github.com) commented 2023-03-16 18:54:21 +00:00
Copy link

microoptimization like that are probably not worth it, if they make code less readable and I kinda doubt that fill is called often enough to be worth it

microoptimization like that are probably not worth it, if they make code less readable and I kinda doubt that fill is called often enough to be worth it
justliliandev (Migrated from github.com) reviewed 2023-03-16 18:59:11 +00:00
src/machines/java/com/enderio/machines/common/item/FluidTankItem.java
justliliandev (Migrated from github.com) commented 2023-03-16 18:59:11 +00:00
Copy link

we technically can, but I've heard about a lot of weird interactions with stackable fluid containers over the years, it's probably not worth the bugs imo

we technically can, but I've heard about a lot of weird interactions with stackable fluid containers over the years, it's probably not worth the bugs imo
justliliandev (Migrated from github.com) reviewed 2023-03-16 19:00:01 +00:00
src/main/java/com/enderio/base/common/blockentity/IWrenchable.java
justliliandev (Migrated from github.com) commented 2023-03-16 19:00:01 +00:00
Copy link

extend nothing and add javadoc

extend nothing and add javadoc
albinaask (Migrated from github.com) reviewed 2023-03-16 19:00:52 +00:00
src/machines/java/com/enderio/machines/common/item/FluidTankItem.java
albinaask (Migrated from github.com) commented 2023-03-16 19:00:52 +00:00
Copy link

I see, it however was one of my very favourite features of EnderIO, I'll see if I can get it to work later on...

I see, it however was one of my very favourite features of EnderIO, I'll see if I can get it to work later on...
justliliandev (Migrated from github.com) approved these changes 2023-03-18 15:53:08 +00:00
justliliandev (Migrated from github.com) left a comment
Copy link

Fix conflicts

Fix conflicts
ferriarnus (Migrated from github.com) reviewed 2023-03-25 12:59:44 +00:00
src/machines/java/com/enderio/machines/common/io/fluid/MachineFluidTank.java
ferriarnus (Migrated from github.com) commented 2023-03-25 12:59:44 +00:00
Copy link

So what exactly is this class for? It does something like a fluid bar, and some things for in world interactions and fluidutil? I seemed to have glossed over this when I first looked, but is this all needed like this?

So what exactly is this class for? It does something like a fluid bar, and some things for in world interactions and fluidutil? I seemed to have glossed over this when I first looked, but is this all needed like this?
albinaask (Migrated from github.com) reviewed 2023-03-26 17:11:37 +00:00
src/machines/java/com/enderio/machines/common/io/fluid/MachineFluidTank.java
albinaask (Migrated from github.com) commented 2023-03-26 17:11:37 +00:00
Copy link

The MachineFluidTank is a class that does similar things to the FluidTank class that Forge provides, it holds data about what type of fluid is contained and how much. It has a capacity and an API for transferring into and out of the tank. The Forge implementation is missing filters for controlling which fluids are allowed to enter and exit the tank. My implementation allows for flagging a tank as for example an input tank accepting only fluids that has the coolant property set for example. It would reject any attempt from external sources to pull coolant out or put lava into the tank. As for the enchantment infuser or whatever it's called you flag it as an input tank and set the predicate to only accept fluidXP and only do it when the machine has a recipe, also set the capacity to whatever amount the recipe requires. This will disallow any fluid from going into the tank until the machine has a valid recipe. Then it only accepts liqudXP and only the amount specified by the recipe. It won't allow liquidXP to be pulled out by pipes, however when you are done with your recipe and want to void the fluid that went into the recipe you just use tank.drain([tank.get_amount()], true) to force it to drain all internal content. The reason to why it is so long is that I had to rewrite like the entire class to enable the predicate and to remove the functionality of storing multiple fluids (like in the tinkers smeltery). If you want to I'll point you towards my unfinished implementation of the vat, but it is still missing all the recipe stuff.

The MachineFluidTank is a class that does similar things to the FluidTank class that Forge provides, it holds data about what type of fluid is contained and how much. It has a capacity and an API for transferring into and out of the tank. The Forge implementation is missing filters for controlling which fluids are allowed to enter and exit the tank. My implementation allows for flagging a tank as for example an input tank accepting only fluids that has the coolant property set for example. It would reject any attempt from external sources to pull coolant out or put lava into the tank. As for the enchantment infuser or whatever it's called you flag it as an input tank and set the predicate to only accept fluidXP and only do it when the machine has a recipe, also set the capacity to whatever amount the recipe requires. This will disallow any fluid from going into the tank until the machine has a valid recipe. Then it only accepts liqudXP and only the amount specified by the recipe. It won't allow liquidXP to be pulled out by pipes, however when you are done with your recipe and want to void the fluid that went into the recipe you just use tank.drain([tank.get_amount()], true) to force it to drain all internal content. The reason to why it is so long is that I had to rewrite like the entire class to enable the predicate and to remove the functionality of storing multiple fluids (like in the tinkers smeltery). If you want to I'll point you towards my unfinished implementation of the vat, but it is still missing all the recipe stuff.
albinaask commented 2023-03-26 17:26:18 +00:00 (Migrated from github.com)
Copy link

I goofed it up bad somehow... submitting the exact same pr again. Sorry for the inconvenience...

I goofed it up bad somehow... submitting the exact same pr again. Sorry for the inconvenience...

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
justliliandev
Labels
Clear labels   
Area-Assets

   
Area-Backend

Backend work not usually visible to players.

  
Area-Conduits

Everything involving conduits

  
Area-Datapacks

   
Area-Lang

   
Area-Mod Compat

   
Area-Parity

1.12.2 missing features

  
Area-Rendering

Rendering code, might be shaders specific or general.

  
Good first issue

   
MC-1.19.2

   
MC-1.20.1

   
MC-1.20.4

   
MC-1.20.6

   
MC-1.21

   
MC-1.21.1

   
Modtoberfest

   
P-0-High

High priority, crash/breaking.

  
P-1-Medium

Medium priority. Potentially deleting items or breaking functionality.

  
P-2-Low

Low priority. Not hurting anyone, just annoying.

  
Status-Awaiting Response

Waiting for OP to respond

  
Status-Behind-Flag

This change is available but is placed behind a feature flag.

  
Status-Blocked

Blocked by a specific issue or protocol.

  
Status-Cannot Reproduce

   
Status-Duplicate

This issue or pull request already exists

  
Status-Help Wanted

We need some help to try and track this thing down..

  
Status-Incomplete Report

   
Status-Invalid

This doesn't seem right

  
Status-Needs LTS Backport

Fixed in latest but requires LTS backport.

  
Status-Needs Updating

Needs updating to a newer Minecraft version.

  
Status-Stale

This may not be updated by the OP any further.

  
Status-To Implement

   
Status-Triage

A Triage Member should take a look at this

  
Status-Wontfix

This will not be worked on

  
Status-Wontmerge

This PR won't be merged, but is left now for reference of ongoing or future works.

  
Type-Backport

   
Type-Bug

There is a problem.

  
Type-Documentation

Improvements or additions to documentation

  
Type-Enhancement

New feature or enhancement to existing feature.

  
Type-Question

Further information is requested

  
Type-RFC

Request for comments.

  
Type-Suggestion
No labels
Area-Assets
Area-Backend
Area-Conduits
Area-Datapacks
Area-Lang
Area-Mod Compat
Area-Parity
Area-Rendering
Good first issue
MC-1.19.2
MC-1.20.1
MC-1.20.4
MC-1.20.6
MC-1.21
MC-1.21.1
Modtoberfest
P-0-High
P-1-Medium
P-2-Low
Status-Awaiting Response
Status-Behind-Flag
Status-Blocked
Status-Cannot Reproduce
Status-Duplicate
Status-Help Wanted
Status-Incomplete Report
Status-Invalid
Status-Needs LTS Backport
Status-Needs Updating
Status-Stale
Status-To Implement
Status-Triage
Status-Wontfix
Status-Wontmerge
Type-Backport
Type-Bug
Type-Documentation
Type-Enhancement
Type-Question
Type-RFC
Type-Suggestion
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#111
No description provided.
Delete branch "machine-fluid-tank-update-branch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?