GitHub Actions Improvements #120

Merged
Rover656 merged 18 commits from feature/actions-data into dev/1.19.x 2023-04-04 21:46:13 +00:00
Rover656 commented 2023-04-01 19:34:50 +00:00 (Migrated from github.com)

Description

Improves our PR validation by adding data generator checks; this means we will ensure contributors have included the up-to-date generated artefacts.
It also ensures that the game is able to start in datagen mode.

Requested review from 2 core maintainers, but feel free to review this change too.

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
# Description Improves our PR validation by adding data generator checks; this means we will ensure contributors have included the up-to-date generated artefacts. It also ensures that the game is able to start in datagen mode. Requested review from 2 core maintainers, but feel free to review this change too. # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation <!-- Thanks to: https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ for the building blocks of this template -->
Rover656 commented 2023-04-01 19:39:00 +00:00 (Migrated from github.com)

Yknow, putting the silicon tag back is a good idea..

Yknow, putting the silicon tag back is a good idea..
ferriarnus (Migrated from github.com) approved these changes 2023-04-04 10:33:54 +00:00
ferriarnus (Migrated from github.com) left a comment

From my understanding of github actions, this seems good!

From my understanding of github actions, this seems good!
justliliandev (Migrated from github.com) approved these changes 2023-04-04 21:38:53 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#120
No description provided.