Team-EnderIO/EnderIO
1
0
Fork 0
Code Issues 114 Pull requests 13 Projects Releases 79 Packages Wiki Activity Actions

New Sync System (Read Desc) #218

Merged
Rover656 merged 5 commits from feature/improved-dataslots into dev/1.20.1 2023-07-07 19:25:26 +00:00
Conversation 6 Commits 5 Files changed 68 +1230 -862
Rover656 commented 2023-07-07 17:12:03 +00:00 (Migrated from github.com)
Copy link

Description

  • Implemented simpler but (seemingly) working data syncing
  • Client now must opt to send data, rather than it being polled for.
  • Conduits no longer use data slots for client -> server, they are done with custom packets to reduce data transmission and hopefully corruption.
  • Some conduit behavioral changes.

Please test this thoroughly. I am actively testing both single and multi-player at the moment.

Todo

  • Proper conduit data slot hash function

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
# Description - Implemented simpler but (seemingly) working data syncing - Client now must opt to send data, rather than it being polled for. - Conduits no longer use data slots for client -> server, they are done with custom packets to reduce data transmission and hopefully corruption. - Some conduit behavioral changes. Please test this thoroughly. I am actively testing both single and multi-player at the moment. # Todo <!-- Remove this section if you're submitting an already-complete PR --> - [ ] Proper conduit data slot hash function # Checklist: - [ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation <!-- Thanks to: https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ for the building blocks of this template -->
ferriarnus (Migrated from github.com) reviewed 2023-07-07 17:12:03 +00:00
justliliandev (Migrated from github.com) reviewed 2023-07-07 17:54:53 +00:00
justliliandev (Migrated from github.com) left a comment
Copy link

code isn't great, but no major concerns

code isn't great, but no major concerns
src/conduits/java/com/enderio/conduits/common/blockentity/ConduitBundle.java
justliliandev (Migrated from github.com) commented 2023-07-07 17:42:05 +00:00
Copy link

this can be reverted

this can be reverted
src/conduits/java/com/enderio/conduits/common/types/FluidExtendedData.java
justliliandev (Migrated from github.com) commented 2023-07-07 17:47:16 +00:00
Copy link

remove

remove
src/conduits/java/com/enderio/conduits/common/types/ItemClientConduitData.java
justliliandev (Migrated from github.com) commented 2023-07-07 17:47:47 +00:00
Copy link

add todo, we can't expect addons to know about core network, nor the package

add todo, we can't expect addons to know about core network, nor the package
src/core/java/com/enderio/core/client/ClientEventHandler.java
justliliandev (Migrated from github.com) commented 2023-07-07 17:48:16 +00:00
Copy link

remove

remove
justliliandev (Migrated from github.com) approved these changes 2023-07-07 17:56:22 +00:00
Rover656 (Migrated from github.com) reviewed 2023-07-07 19:09:19 +00:00
src/conduits/java/com/enderio/conduits/common/types/ItemClientConduitData.java
Rover656 (Migrated from github.com) commented 2023-07-07 19:09:19 +00:00
Copy link

Yeah ideally in future we pass a consumer or something that lets them sync without knowledge of core

Yeah ideally in future we pass a consumer or something that lets them sync without knowledge of core
justliliandev (Migrated from github.com) approved these changes 2023-07-07 19:23:56 +00:00
justliliandev (Migrated from github.com) left a comment
Copy link

havn't found any issues

havn't found any issues
Rover656 commented 2023-07-07 19:24:44 +00:00 (Migrated from github.com)
Copy link

Yeah I've been quite happy in my testing too; gonna hit go. Cheers for looking over it!

Yeah I've been quite happy in my testing too; gonna hit go. Cheers for looking over it!
Sign in to join this conversation.
Reviewers
No reviewers
ferriarnus
justliliandev
Labels
Clear labels   
Area-Assets

   
Area-Backend

Backend work not usually visible to players.

  
Area-Conduits

Everything involving conduits

  
Area-Datapacks

   
Area-Lang

   
Area-Mod Compat

   
Area-Parity

1.12.2 missing features

  
Area-Rendering

Rendering code, might be shaders specific or general.

  
Good first issue

   
MC-1.19.2

   
MC-1.20.1

   
MC-1.20.4

   
MC-1.20.6

   
MC-1.21

   
MC-1.21.1

   
Modtoberfest

   
P-0-High

High priority, crash/breaking.

  
P-1-Medium

Medium priority. Potentially deleting items or breaking functionality.

  
P-2-Low

Low priority. Not hurting anyone, just annoying.

  
Status-Awaiting Response

Waiting for OP to respond

  
Status-Behind-Flag

This change is available but is placed behind a feature flag.

  
Status-Blocked

Blocked by a specific issue or protocol.

  
Status-Cannot Reproduce

   
Status-Duplicate

This issue or pull request already exists

  
Status-Help Wanted

We need some help to try and track this thing down..

  
Status-Incomplete Report

   
Status-Invalid

This doesn't seem right

  
Status-Needs LTS Backport

Fixed in latest but requires LTS backport.

  
Status-Needs Updating

Needs updating to a newer Minecraft version.

  
Status-Stale

This may not be updated by the OP any further.

  
Status-To Implement

   
Status-Triage

A Triage Member should take a look at this

  
Status-Wontfix

This will not be worked on

  
Status-Wontmerge

This PR won't be merged, but is left now for reference of ongoing or future works.

  
Type-Backport

   
Type-Bug

There is a problem.

  
Type-Documentation

Improvements or additions to documentation

  
Type-Enhancement

New feature or enhancement to existing feature.

  
Type-Question

Further information is requested

  
Type-RFC

Request for comments.

  
Type-Suggestion
No labels
Area-Assets
Area-Backend
Area-Conduits
Area-Datapacks
Area-Lang
Area-Mod Compat
Area-Parity
Area-Rendering
Good first issue
MC-1.19.2
MC-1.20.1
MC-1.20.4
MC-1.20.6
MC-1.21
MC-1.21.1
Modtoberfest
P-0-High
P-1-Medium
P-2-Low
Status-Awaiting Response
Status-Behind-Flag
Status-Blocked
Status-Cannot Reproduce
Status-Duplicate
Status-Help Wanted
Status-Incomplete Report
Status-Invalid
Status-Needs LTS Backport
Status-Needs Updating
Status-Stale
Status-To Implement
Status-Triage
Status-Wontfix
Status-Wontmerge
Type-Backport
Type-Bug
Type-Documentation
Type-Enhancement
Type-Question
Type-RFC
Type-Suggestion
Milestone
Clear milestone
No items
No milestone
First Alpha Release (v6.0)
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#218
No description provided.
Delete branch "feature/improved-dataslots"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?