[RFC] Machine item consumption #323

New issue

Closed

opened 2023-07-21 08:44:24 +00:00 by Rover656 · 4 comments

Rover656 commented

2023-07-21 08:44:24 +00:00

(Migrated from github.com)

1.12 Ender IO, a machine will consume its ingredients before starting to craft its recipe. We implemented machines like this for parity, but it has come up in conversation and my own thinking that this is inherently inconsistent with literally the rest of minecraft. This issue serves as a place to discuss pros and cons of both, and opinions thereof to try and decide if we should retain this behaviour or align ourselves with vanilla behaviours.

dphaldes commented

2023-07-21 09:48:59 +00:00

(Migrated from github.com)

In my opinion, the EnderIO way is very confusing.
Imagine if a player wants to craft/process 2 distinct items A and B. As soon as the player inputs ingredients for A, they instantly get consumed and all machine slots are empty. The player doesn't realize that machine is processing (as the only visual cue is the progress bar and sometimes is super slow).
The player thinks the machine is bugged or something and inputs ingredients of B in the machine (since the input slots are empty). When the original process finishes, the machine outputs A and consumes B's ingredients in the same tick which is even more confusing.

Another problem with the EnderIO way is that there is no way to figure out what the machine is already processing until the process finishes.

In my opinion, the EnderIO way is very confusing. Imagine if a player wants to craft/process 2 distinct items A and B. As soon as the player inputs ingredients for A, they instantly get consumed and all machine slots are empty. The player doesn't realize that machine is processing (as the only visual cue is the progress bar and sometimes is super slow). The player thinks the machine is bugged or something and inputs ingredients of B in the machine (since the input slots are empty). When the original process finishes, the machine outputs A and consumes B's ingredients in the same tick which is even more confusing. Another problem with the EnderIO way is that there is no way to figure out what the machine is already processing until the process finishes.

👍 2

justliliandev commented

2023-07-23 22:30:27 +00:00

(Migrated from github.com)

yeah not sure about this one, doing it like this has some benefits and it isn't too weird imo, because a lot of other mods do it similarly

DarthJake commented

2023-07-24 08:19:28 +00:00

(Migrated from github.com)

I envision each machine having a custom one of these. Some ideas I have off the top of my head:

Alloy Smelter: The items are squished together (really just their stacks overlapping) and then zapped with electricity, and then loops. (I made a quick animation that I actually spent too long on and its one of the ugliest things I've ever made. I'm sorry, I'm not an artist lol)
Primitive Alloy Smelter: Similar but not pushed together and just in a flame
Sag Mill: Saw going across the top/bottom of the item.
Painting Machine: Paint roller moving across the block
Vat: Whirlpool or perhaps some sort of stirring

Like I said, implementing it could be a little tricky but I think it could add some spice to the regular vanilla white progress arrow. I'm sure there are some talented artists around here that could run with this idea and make something a million times better than my abomination of an example 😆. Thoughts?

I had an interesting idea regarding this. It's a little out there and would require some work, however, I believe it could be super cool and really give EnderIO machine menus a little spice. What if we keep the items getting consumed when the craft starts, but instead of having them completely disappear, they are added to an animation that is a souped up version of the white loading/processing arrow. This way it is very apparent what operation the machine is currently performing. I envision each machine having a custom one of these. Some ideas I have off the top of my head: - Alloy Smelter: The items are squished together (really just their stacks overlapping) and then zapped with electricity, and then loops. (I made a quick animation that I actually spent too long on and its one of the ugliest things I've ever made. I'm sorry, I'm not an artist lol) ![alloyLoop](https://github.com/SleepyTrousers/EnderIO-Rewrite/assets/19763416/ab9e3d34-17a5-42eb-ac22-e92990fae8ff) - Primitive Alloy Smelter: Similar but not pushed together and just in a flame - Sag Mill: Saw going across the top/bottom of the item. - Painting Machine: Paint roller moving across the block - Vat: Whirlpool or perhaps some sort of stirring Like I said, implementing it could be a little tricky but I think it could add some spice to the regular vanilla white progress arrow. I'm sure there are some talented artists around here that could run with this idea and make something a million times better than my abomination of an example :laughing:. Thoughts?

Rover656 commented

2023-07-24 19:23:58 +00:00

(Migrated from github.com)

I'm not sure I'm a massive fan of this idea, as it doesn't fix some of the technical disadvantages regarding immediate consumption of ingredients. It seems like a really cool concept, but I'm unsure if it really fits in with Ender IO either tbh. Thanks so much for your in-depth discussion of your idea though; really really cool stuff!

👍 1