Fix exp display for the SoulBinder #363

Merged

ferriarnus merged 4 commits from soulbinder-fixes into dev/1.20.1

2023-11-11 15:30:03 +00:00

ferriarnus commented

2023-07-27 15:59:36 +00:00

(Migrated from github.com)

Description

Fix exp display for the SoulBinder

Closes #(issue)

Todo

There are other issues related to the soulbinder, but I was unable to confirm these.

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
I have performed a self-review of my own code.
I have commented my code in areas it may be challenging to understand.
I have made corresponding changes to the documentation.
My changes are ready for review from a contributor.

# Description Fix exp display for the SoulBinder Closes #(issue)   # Todo - [ ] There are other issues related to the soulbinder, but I was unable to confirm these.  # Checklist: - [ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [ ] I have performed a self-review of my own code. - [ ] I have commented my code in areas it may be challenging to understand.  - [ ] I have made corresponding changes to the documentation. - [ ] My changes are ready for review from a contributor.

justliliandev (Migrated from github.com) reviewed

2023-08-09 13:09:36 +00:00

justliliandev commented

2023-08-09 13:10:39 +00:00

(Migrated from github.com)

mergable once conflict is resolved

ferriarnus commented

2023-08-09 14:09:57 +00:00

(Migrated from github.com)

I think rover wanted me to take a look into using a recipe cache for it, so I might do that before finishing.

👍 1

Rover656 (Migrated from github.com) requested changes

2023-08-18 23:13:18 +00:00

Rover656 (Migrated from github.com) left a comment

Just for tracking purposes, marking as requested changes for the move into the recipe cache :)

Rover656 (Migrated from github.com) reviewed

2023-11-11 13:56:19 +00:00

Rover656 (Migrated from github.com) left a comment

Dismissing previous comments to get this in as its still causing confusion - the requested enhancement is tracked by #557. If you don't have time to by the time I reach a PC, I'll resolve conflicts and merge soon. Thank you Ferri!