[BUG] Ensure energy buffer is retained when changing/upgrading capacitor. #444

New issue

Closed

opened 2023-08-10 22:17:14 +00:00 by Rover656 · 6 comments

Rover656 commented

2023-08-10 22:17:14 +00:00

(Migrated from github.com)

Is there an existing issue for this?

I have searched the existing issues

Current Behavior

Currently removal of capacitor voids energy.

Expected Behavior

It might be nice for the energy to be conserved.

Steps To Reproduce

No response

Environment

No response

Anything else?

No response

### Is there an existing issue for this? - [X] I have searched the existing issues ### Current Behavior Currently removal of capacitor voids energy. ### Expected Behavior It might be nice for the energy to be conserved. ### Steps To Reproduce _No response_ ### Environment _No response_ ### Anything else? _No response_

dphaldes commented

2023-08-11 08:41:59 +00:00

(Migrated from github.com)

Should energy be stored in the machine in a locked state or should it be attached to the cap ?

Rover656 commented

2023-08-11 09:07:21 +00:00

(Migrated from github.com)

I thought about attaching to the cap, but i dont know if that kinda ruins upgrades, and i dont really wanna write a machines energy to an itemstack. Maybe just storing the buffer internally is better

👍 1

MinePlay96 commented

2023-08-16 17:28:32 +00:00

(Migrated from github.com)

How should it be handled if the cap is a downgrade?

How about the capacitor is getting "charged" and all machines have the same capacity with the same type of capacitor. In this case the capacitor is acting like the internal power storage of the machine.

How should it be handled if the cap is a downgrade? How about the capacitor is getting "charged" and all machines have the same capacity with the same type of capacitor. In this case the capacitor is acting like the internal power storage of the machine.

Rover656 commented

2023-08-16 17:33:40 +00:00

(Migrated from github.com)

I don't like the idea of charging the capacitor as stated earlier in the conversation. If you downgraded the cap I think its fair to say you'd just lose the extra above that caps ability.

Rover656 commented

2024-06-06 21:03:28 +00:00

(Migrated from github.com)

Fixed in dev, but requires LTS backport.

Rover656 commented

2024-06-06 21:20:02 +00:00

(Migrated from github.com)

Backported.