Team-EnderIO/EnderIO

the 1.18 pr, but moved to api with an example usage for tinkers #61

Merged

justliliandev merged 2 commits from feature/powerful_integration1.19.x into dev/1.19.x

2022-07-05 10:30:41 +00:00

justliliandev commented

2022-07-02 17:48:09 +00:00

(Migrated from github.com)

Description

Integration was moved to api, so other mods can easily alter our behavior, if they wish.

I would also like some feedback if Integration should be part of api, as this could be something really easy to implement for others to change our behavior

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

# Description Integration was moved to api, so other mods can easily alter our behavior, if they wish. I would also like some feedback if Integration should be part of api, as this could be something really easy to implement for others to change our behavior # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation

CrazyPants (Migrated from github.com) reviewed

2022-07-02 17:48:09 +00:00

Rover656 (Migrated from github.com) reviewed

2022-07-02 17:48:09 +00:00

ferriarnus (Migrated from github.com) reviewed

2022-07-02 17:48:09 +00:00

EpicSquid (Migrated from github.com) reviewed

2022-07-04 23:05:57 +00:00

EpicSquid (Migrated from github.com) left a comment

Looks good, just want to understand why the setModid method works the way it does.

Looks good, just want to understand why the setModid method works the way it does.

src/api/java/com/enderio/api/integration/Integration.java

					
				@ -0,0 +1,28 @@

				package com.enderio.api.integration;

EpicSquid (Migrated from github.com) commented

2022-07-04 23:00:05 +00:00

Not to be a pedant, but there should be a space between IntegrationMethods and the {

Not to be a pedant, but there should be a space between IntegrationMethods and the {

src/api/java/com/enderio/api/integration/Integration.java

					
				@ -0,0 +19,4 @@

				     */

				    public void setModid(String modid) {

				        if (this.modid != null)

				            throw new IllegalCallerException("You are not allowed to set the modid of an integration");

EpicSquid (Migrated from github.com) commented

2022-07-04 23:05:28 +00:00

I'm a little confused why we are handling it like this. Can you walk me through this either here or in discord?

I'm a little confused why we are handling it like this. Can you walk me through this either here or in discord?

EpicSquid (Migrated from github.com) approved these changes

2022-07-05 09:31:09 +00:00

EpicSquid (Migrated from github.com) left a comment

Looks good, thanks!

Looks good, thanks!

Sign in to join this conversation.

No reviewers

No labels

Area-Mod Compat

Good first issue

Status-Awaiting Response

Status-Behind-Flag

Status-Cannot Reproduce

Status-Duplicate

Status-Help Wanted

Status-Incomplete Report

Status-Needs LTS Backport

Status-Needs Updating

Status-To Implement

Status-Wontmerge

Type-Documentation

Type-Enhancement

Type-Suggestion

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#61

No description provided.