Bug Report loot_capacitor_template not working as expected #765

Open
opened 2024-07-30 11:22:44 +00:00 by mamaruo · 1 comment
mamaruo commented 2024-07-30 11:22:44 +00:00 (Migrated from github.com)

Is there an existing issue for this?

  • I did not find any existing issues.

Current Behavior

"item.enderio.loot_capacitor_template": "%s %s %s", in language file does not work well. I think the three indicate extra modifier level, extra modifier type, base modifier level. See Crowdin comment for my full understading.

And when I remove spaces, like %s%s%s, the translated name still contains spaces.
image

In addition, %[argument_index$]s syntax does not work as well, like %2$s%1$s%s.

Looks like this template didn't work at all.

Expected Behavior

item.enderio.loot_capacitor_template can control the format of loot capacitor's name, so adapt to the language without Spaces and the word order of some languages.

Chinese without spaces looks like this.
image

How to Test

  1. Change the item.enderio.loot_capacitor_template in language file of any language.
  2. Move the json to a right path. for me "\resourcepacks\Ender IO localization\assets\enderio\lang\zh_cn.json"
  3. Change game language to what language file in step 2 specifies.
  4. Load the resource pack and find a Loot Capacitor.
  5. See the name.

Local Environment

- **Operating System**: Windows 11
- **Java version**: 17.0.6
- **Minecraft Version**: 1.20.1
- **Version**: 6.1.8-beta
- **Other Mods**: Untranslated Items

Any Additional Information?

No response

### Is there an existing issue for this? - [X] I did not find any existing issues. ### Current Behavior `"item.enderio.loot_capacitor_template": "%s %s %s",` in language file does not work well. I think the three indicate extra modifier level, extra modifier type, base modifier level. See [Crowdin](https://crowdin.com/editor/modern-ender-io/48/en-zhcn?view=comfortable&filter=basic&value=0#q=item.enderio.loot_capacitor_template) comment for my full understading. And when I remove spaces, like `%s%s%s`, the translated name still contains spaces. ![image](https://github.com/user-attachments/assets/4af5cd72-3b57-4f09-b133-ca9c3dc4aeb3) In addition, %[argument_index$]s syntax does not work as well, like `%2$s%1$s%s`. Looks like this template didn't work at all. ### Expected Behavior item.enderio.loot_capacitor_template can control the format of loot capacitor's name, so adapt to the language without Spaces and the word order of some languages. Chinese without spaces looks like this. ![image](https://github.com/user-attachments/assets/77243cca-4f12-49b1-b04a-f02c3329f66e) ### How to Test 1. Change the item.enderio.loot_capacitor_template in language file of any language. 2. Move the json to a right path. for me `"\resourcepacks\Ender IO localization\assets\enderio\lang\zh_cn.json"` 3. Change game language to what language file in step 2 specifies. 4. Load the resource pack and find a Loot Capacitor. 5. See the name. ### Local Environment ```markdown - **Operating System**: Windows 11 - **Java version**: 17.0.6 - **Minecraft Version**: 1.20.1 - **Version**: 6.1.8-beta - **Other Mods**: Untranslated Items ``` ### Any Additional Information? _No response_
Rover656 commented 2024-09-27 11:27:10 +00:00 (Migrated from github.com)

Do you have any suggestions on how we could change this template to better suit the needs of the translations? Thanks!

Do you have any suggestions on how we could change this template to better suit the needs of the translations? Thanks!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#765
No description provided.