Tag support for xp bottles #902

New issue

Open

opened 2024-11-23 18:03:22 +00:00 by MuteTiefling · 2 comments

MuteTiefling commented

2024-11-23 18:03:22 +00:00

(Migrated from github.com)

Is there an existing proposal for this?

I did not find any existing requests.

Explain your idea

https://github.com/Team-EnderIO/EnderIO/blob/dev%2F1.21.1/enderio-machines%2Fsrc%2Fgenerated%2Fresources%2Fdata%2Fenderio%2Frecipe%2Ftank_empty%2Fglass_bottle.json

Currently, this recipe requires enderio xp fluid. It would be nice if it accepted any xp fluid by tag instead.

Why do you thing this feature belongs in Ender IO.

General compatibility.

Are there any alternatives?

No response

Any Additional Information?

No response

### Is there an existing proposal for this? - [x] I did not find any existing requests. ### Explain your idea https://github.com/Team-EnderIO/EnderIO/blob/dev%2F1.21.1/enderio-machines%2Fsrc%2Fgenerated%2Fresources%2Fdata%2Fenderio%2Frecipe%2Ftank_empty%2Fglass_bottle.json Currently, this recipe requires enderio xp fluid. It would be nice if it accepted any xp fluid by tag instead. ### Why do you thing this feature belongs in Ender IO. General compatibility. ### Are there any alternatives? _No response_ ### Any Additional Information? _No response_

👍 1

Rover656 commented

2024-12-10 15:57:26 +00:00

(Migrated from github.com)

This would result in a breaking change.

I know what needs to be done for this, but I'd love to know who's using custom tank recipes before I go ahead and break this.

Hmm, in order to do this I think we might need to do some reconfiguring of the tank recipes - I'd have to make the emptying recipes use the FluidIngredient class, but we wouldn't be able to use this for the filling recipes. This would result in a breaking change. I know what needs to be done for this, but I'd love to know who's using custom tank recipes before I go ahead and break this.

MuteTiefling commented

2024-12-10 16:48:12 +00:00

(Migrated from github.com)

We are, but only as a workaround for this :D https://github.com/EnigmaticaModpacks/Enigmatica10/blob/master/kubejs/server_scripts/recipes/enderio/tank.js

👍 2