1.19.4 Port #116

Merged

Rover656 merged 29 commits from update/1.19.4 into dev/1.19.4

2023-06-09 11:53:22 +00:00

Rover656 commented

2023-03-29 00:41:28 +00:00

(Migrated from github.com)

Description

This is the 1.19.4 Port tracker.
The todo list below will show how much more progress is required before the mod works and functions well on 1.19.4, however this will not merge until the waiting list has been merged and accounted for in this PR.

Any PR made after this one however may be missed in this port effort.

Todo

Write an actual TODO list
Get all code to build
Swap to the new widget tooltips system
Verify all functionality
Rewrite and ~~tidy~~ data generators. (tidy postponed, broken ones are rewritten though)

Waiting List

These are the PRs that will be merged prior to this port.

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

# Description This is the 1.19.4 Port tracker. The todo list below will show how much more progress is required before the mod works and functions well on 1.19.4, however this will not merge until the waiting list has been merged and accounted for in this PR. Any PR made after this one however may be missed in this port effort. # Todo  - [x] Write an actual TODO list - [x] Get all code to build - [x] Swap to the new widget tooltips system - [x] Verify all functionality - [x] Rewrite and ~~tidy~~ data generators. (tidy postponed, broken ones are rewritten though) # Waiting List These are the PRs that will be merged prior to this port. - #115 - #92 - #108 - #121 - #120 - #119 # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation

justliliandev (Migrated from github.com) reviewed

2023-03-29 00:41:28 +00:00

ferriarnus (Migrated from github.com) reviewed

2023-03-29 00:41:28 +00:00

Rover656 commented

2023-06-08 11:41:06 +00:00

(Migrated from github.com)

Ready for merge now, any past PRs should be updated to target 1.19.4 branch, and new PRs should target this by default.

Rover656 commented

2023-06-08 11:43:09 +00:00

(Migrated from github.com)

Requested review from either @agnor99 or @ferriarnus, don't mind who just to double check this before it goes in :)