Configurable fluid tank capacity #855
No reviewers
Labels
No labels
Area-Assets
Area-Backend
Area-Conduits
Area-Datapacks
Area-Lang
Area-Mod Compat
Area-Parity
Area-Rendering
Good first issue
MC-1.19.2
MC-1.20.1
MC-1.20.4
MC-1.20.6
MC-1.21
MC-1.21.1
Modtoberfest
P-0-High
P-1-Medium
P-2-Low
Status-Awaiting Response
Status-Behind-Flag
Status-Blocked
Status-Cannot Reproduce
Status-Duplicate
Status-Help Wanted
Status-Incomplete Report
Status-Invalid
Status-Needs LTS Backport
Status-Needs Updating
Status-Stale
Status-To Implement
Status-Triage
Status-Wontfix
Status-Wontmerge
Type-Backport
Type-Bug
Type-Documentation
Type-Enhancement
Type-Question
Type-RFC
Type-Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Team-EnderIO/EnderIO#855
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dev/1.21.1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
Added option to change the fluid capacity of fluid tanks
seams i messed up something
okay from what i see to get this syncing properly on servers this would requre a rewrite of the fluid tanks witch i am to dumb to do so i am just going to leave this here if someone wants to pick it up and finish it. the config is there i just dont know how to sync the capacity over to the client
@davidCMs should we consider this PR as abandoned ?
Also, do explain what parts for tank needs refactoring.
I just made the additions to the configs but i don't know how to make it work in multiplayer so as far as i know the tank classes need refactoring to sync the max capacity with the client but i am not familiar enough with forge to do that, i have looked at how the max energy config is done but i don't entirely understand how that works. I don't plan on editing this further i just left it here in case someone knows how to make it work in multiplayer so they have the configs all ready made .
Closing this for now, we should be able to address this differently once #1049 is addressed :)
Thanks for taking an attempt at this!
Pull request closed