Configurable fluid tank capacity #855

Closed
davidCMs wants to merge 2 commits from dev/1.21.1 into dev/1.21.1
davidCMs commented 2024-10-08 18:25:41 +00:00 (Migrated from github.com)

Description

Added option to change the fluid capacity of fluid tanks

# Description Added option to change the fluid capacity of fluid tanks
davidCMs commented 2024-10-09 12:25:27 +00:00 (Migrated from github.com)

seams i messed up something

seams i messed up something
davidCMs commented 2024-10-09 13:19:03 +00:00 (Migrated from github.com)

okay from what i see to get this syncing properly on servers this would requre a rewrite of the fluid tanks witch i am to dumb to do so i am just going to leave this here if someone wants to pick it up and finish it. the config is there i just dont know how to sync the capacity over to the client

okay from what i see to get this syncing properly on servers this would requre a rewrite of the fluid tanks witch i am to dumb to do so i am just going to leave this here if someone wants to pick it up and finish it. the config is there i just dont know how to sync the capacity over to the client
dphaldes commented 2024-12-15 19:39:09 +00:00 (Migrated from github.com)

@davidCMs should we consider this PR as abandoned ?
Also, do explain what parts for tank needs refactoring.

@davidCMs should we consider this PR as abandoned ? Also, do explain what parts for tank needs refactoring.
davidCMs commented 2024-12-15 20:40:43 +00:00 (Migrated from github.com)

I just made the additions to the configs but i don't know how to make it work in multiplayer so as far as i know the tank classes need refactoring to sync the max capacity with the client but i am not familiar enough with forge to do that, i have looked at how the max energy config is done but i don't entirely understand how that works. I don't plan on editing this further i just left it here in case someone knows how to make it work in multiplayer so they have the configs all ready made .

I just made the additions to the configs but i don't know how to make it work in multiplayer so as far as i know the tank classes need refactoring to sync the max capacity with the client but i am not familiar enough with forge to do that, i have looked at how the max energy config is done but i don't entirely understand how that works. I don't plan on editing this further i just left it here in case someone knows how to make it work in multiplayer so they have the configs all ready made .
Rover656 commented 2025-04-25 22:10:34 +00:00 (Migrated from github.com)

Closing this for now, we should be able to address this differently once #1049 is addressed :)
Thanks for taking an attempt at this!

Closing this for now, we should be able to address this differently once #1049 is addressed :) Thanks for taking an attempt at this!

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#855
No description provided.