Add transceiver (#146) #1111

Open
Trytoon wants to merge 3 commits from Trytoon/146-dimensional-transceiver into dev/1.21.1
Trytoon commented 2025-07-25 19:36:50 +00:00 (Migrated from github.com)

Description

Added the dimensiional transceiver back to the game !

TODO

  • Add Block Entity
  • Create channel system
  • Implement logic for block entity (send/ receive tasks)
  • Improve GUI
  • Block rendering

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.
# Description Added the dimensiional transceiver back to the game ! <!-- If you're submitting a Draft PR, consider providing a TODO list using checkboxes --> # TODO - [X] Add Block Entity - [X] Create channel system - [ ] Implement logic for block entity (send/ receive tasks) - [ ] Improve GUI - [ ] Block rendering <!-- For drafts, fill this in as you go; if you are leaving draft, make sure these are all complete. --> # Checklist - [ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [ ] I have made corresponding changes to the documentation. - [ ] My changes are ready for review from a contributor. <!-- Thanks to: https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ for the building blocks of this template -->
coderabbitai[bot] commented 2025-07-25 19:36:59 +00:00 (Migrated from github.com)

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: skip review by coderabbit.ai --> > [!IMPORTANT] > ## Review skipped > > Draft detected. > > Please check the settings in the CodeRabbit UI or the `.coderabbit.yaml` file in this repository. To trigger a single review, invoke the `@coderabbitai review` command. > > You can disable this status message by setting the `reviews.review_status` to `false` in the CodeRabbit configuration file. <!-- end of auto-generated comment: skip review by coderabbit.ai --> <!-- finishing_touch_checkbox_start --> <details> <summary>✨ Finishing Touches</summary> <details> <summary>🧪 Generate unit tests</summary> - [ ] <!-- {"checkboxId": "f47ac10b-58cc-4372-a567-0e02b2c3d479", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Create PR with unit tests - [ ] <!-- {"checkboxId": "07f1e7d6-8a8e-4e23-9900-8731c2c87f58", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Post copyable unit tests in a comment </details> </details> <!-- finishing_touch_checkbox_end --> <!-- tips_start --> --- Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. <details> <summary>❤️ Share</summary> - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) </details> <details> <summary>🪧 Tips</summary> ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=Team-EnderIO/EnderIO&utm_content=1111): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit <commit_id>, please review it.` - `Explain this complex logic.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai explain this code block.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and explain its main purpose.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` ### Support Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR. - `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR. - `@coderabbitai generate unit tests` to generate unit tests for this PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements. </details> <!-- tips_end -->
justliliandev (Migrated from github.com) reviewed 2025-09-27 08:27:10 +00:00
@ -0,0 +7,4 @@
import java.util.concurrent.CopyOnWriteArrayList;
import java.util.concurrent.atomic.AtomicInteger;
public class RoundRobinList<T> {
justliliandev (Migrated from github.com) commented 2025-09-27 07:48:22 +00:00

pls fully implement List or at least make it iterable, so that an enhanced for loop can be used

pls fully implement List or at least make it iterable, so that an enhanced for loop can be used
@ -0,0 +82,4 @@
}
private Set<Channel> calculateAvailableChannels(Set<Channel> allChannels, Set<Channel> sendChannels, Set<Channel> receiveChannels) {
Set<Channel> availableChannels = new LinkedHashSet<>();
justliliandev (Migrated from github.com) commented 2025-09-27 07:59:29 +00:00

is there a reason to use a LinkedHashSet instead of the usual HashSet here? Creating a copy of AllChannels and removingAll receive/send channels might be simpler

is there a reason to use a LinkedHashSet instead of the usual HashSet here? Creating a copy of AllChannels and removingAll receive/send channels might be simpler
@ -0,0 +42,4 @@
private static final int CHANNEL_NAME_MAX_LENGTH = 50;
public record Config(TransceiverScreen screen, Set<Channel> availableChannels, Set<Channel> sendChannels, Set<Channel> receiveChannels, int x, int y, int width, int height) {
justliliandev (Migrated from github.com) commented 2025-09-27 08:03:52 +00:00

move inner classes below the methods/fields of the outer class

move inner classes below the methods/fields of the outer class
@ -0,0 +53,4 @@
this.width = width;
this.height = height;
}
}
justliliandev (Migrated from github.com) commented 2025-09-27 08:02:47 +00:00

fix indentation

fix indentation
@ -0,0 +151,4 @@
return new IconButton(x, y, 16, 16, ICON_ARROWS, Component.empty(), this::handleReceiveButton);
}
private ChannelOperations createChannelOperations(TransceiverScreen screen) {
justliliandev (Migrated from github.com) commented 2025-09-27 08:07:01 +00:00

is there a reason that ChannelOperations is an interface with a single anonymous impl? Can it be turned into a normal class?

is there a reason that ChannelOperations is an interface with a single anonymous impl? Can it be turned into a normal class?
@ -0,0 +15,4 @@
import java.util.Set;
import java.util.stream.Collectors;
public class ChannelList extends EnumMap<ChannelType, LinkedHashSet<Channel>> {
justliliandev (Migrated from github.com) commented 2025-09-27 08:17:50 +00:00

why is this a LinkedHashSet?

why is this a LinkedHashSet?
This pull request has changes conflicting with the target branch.
  • endercore/src/main/java/com/enderio/core/client/gui/screen/EnderContainerScreen.java
  • enderio-base/src/main/java/com/enderio/base/common/lang/EIOLang.java
  • enderio-machines/src/generated/resources/assets/enderio/lang/en_us.json
  • enderio-machines/src/generated/resources/data/minecraft/tags/block/mineable/pickaxe.json
  • enderio-machines/src/generated/resources/data/minecraft/tags/block/needs_iron_tool.json
  • enderio-machines/src/main/java/com/enderio/machines/common/init/MachineBlockEntities.java
  • enderio-machines/src/main/java/com/enderio/machines/common/init/MachineMenus.java
  • enderio-machines/src/main/java/com/enderio/machines/common/init/MachineNetwork.java
  • enderio/src/generated/resources/assets/enderio/blockstates/transceiver.json
  • enderio/src/generated/resources/assets/enderio/lang/en_us.json
  • enderio/src/generated/resources/assets/enderio/models/block/transceiver_active_combined.json
  • enderio/src/generated/resources/assets/enderio/models/block/transceiver_combined.json
  • enderio/src/generated/resources/assets/enderio/models/item/transceiver.json
  • enderio/src/generated/resources/data/enderio/loot_table/blocks/transceiver.json
  • enderio/src/main/java/com/enderio/enderio/client/content/machines/gui/screen/TransceiverScreen.java
  • enderio/src/main/java/com/enderio/enderio/client/foundation/widgets/ChannelSelectWidget.java
  • enderio/src/main/java/com/enderio/enderio/foundation/network/MachinePayloadHandler.java
  • enderio/src/main/resources/assets/enderio/models/block/transceiver.json
  • enderio/src/main/resources/assets/enderio/textures/gui/sprites/buttons/arrows.png
  • enderio/src/main/resources/assets/enderio/textures/gui/sprites/buttons/channel_add.png
  • enderio/src/main/resources/assets/enderio/textures/gui/sprites/buttons/channel_delete.png
  • enderio/src/main/resources/assets/enderio/textures/gui/sprites/buttons/channel_private.png
  • enderio/src/main/resources/assets/enderio/textures/gui/sprites/buttons/channel_public.png
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin Trytoon/146-dimensional-transceiver:Trytoon/146-dimensional-transceiver
git switch Trytoon/146-dimensional-transceiver

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch dev/1.21.1
git merge --no-ff Trytoon/146-dimensional-transceiver
git switch Trytoon/146-dimensional-transceiver
git rebase dev/1.21.1
git switch dev/1.21.1
git merge --ff-only Trytoon/146-dimensional-transceiver
git switch Trytoon/146-dimensional-transceiver
git rebase dev/1.21.1
git switch dev/1.21.1
git merge --no-ff Trytoon/146-dimensional-transceiver
git switch dev/1.21.1
git merge --squash Trytoon/146-dimensional-transceiver
git switch dev/1.21.1
git merge --ff-only Trytoon/146-dimensional-transceiver
git switch dev/1.21.1
git merge Trytoon/146-dimensional-transceiver
git push origin dev/1.21.1
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#1111
No description provided.