fix: Unify conduit placement logic (1.20.1) #1139

Merged

DoctorNefario merged 1 commit from fix/conduit-placement into dev/1.20.1

2025-10-06 20:44:38 +00:00

DoctorNefario commented

2025-09-20 06:56:20 +00:00

(Migrated from github.com)

Description

ConduitBlockItem logic was out of sync with ConduitBlock, causing items to be deleted. Both classes now use ConduitBlock's logic.

Fixes #986 (1.20.1 only)

Checklist

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
I have made corresponding changes to the documentation.
My changes are ready for review from a contributor.

# Description ConduitBlockItem logic was out of sync with ConduitBlock, causing items to be deleted. Both classes now use ConduitBlock's logic. Fixes #986 (1.20.1 only)  # Checklist - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [x] I have made corresponding changes to the documentation. - [x] My changes are ready for review from a contributor.

CitiesXL2815 commented

2025-09-21 02:23:32 +00:00

(Migrated from github.com)

this issue was possibly fixed in V8, fix may need to backported from V8 tho

Rover656 (Migrated from github.com) approved these changes

2025-10-06 20:44:29 +00:00

Rover656 (Migrated from github.com) left a comment

Looks good to me, thank you!