[WIP] Fixed shading and moved endercore to a separate repo. #12

Closed
Rover656 wants to merge 12 commits from fix-shade into dev/1.18.x
Rover656 commented 2021-12-30 00:01:23 +00:00 (Migrated from github.com)

Description

Moves endercore out to its own repo, brings it in over maven and takes shadowing out of this project completely, fixing the problem with duplicating registrate code.

Todo

  • Setup the endercore repository
  • Get endercore publishing to maven
  • Setup maven properly in this project
  • Final checks

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
# Description Moves endercore out to its own repo, brings it in over maven and takes shadowing out of this project completely, fixing the problem with duplicating registrate code. # Todo <!-- Remove this section if you're submitting an already-complete PR --> - [ ] Setup the endercore repository - [ ] Get endercore publishing to maven - [ ] Setup maven properly in this project - [ ] Final checks # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation <!-- Thanks to: https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ for the building blocks of this template -->
Rover656 commented 2021-12-30 00:01:57 +00:00 (Migrated from github.com)

Builds will fail due to unavailability of EnderCore over maven. This'll get fixed once maven publishing is setup on a new repo for EnderCore.

Builds will fail due to unavailability of EnderCore over maven. This'll get fixed once maven publishing is setup on a new repo for EnderCore.
Rover656 commented 2021-12-31 00:20:12 +00:00 (Migrated from github.com)

Massively overcomplex compared to a new solution that should've taken 10 mins

Massively overcomplex compared to a new solution that should've taken 10 mins

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#12
No description provided.