Da vatatron finally ready ish. #122

Closed

albinaask wants to merge 4 commits from vat-update-branch into dev/1.19.x

albinaask commented

2023-04-08 21:34:18 +00:00

(Migrated from github.com)

Description

Implements the Vat along with some test recipes

Todo

Custom processing widget, this is not made since the widgets are to be rewrited for 1.19.4 if I recall correctly.
Custom processing widget for the JEI integration.
Fluid tank update needs to be merged before this.
This code must be rebased to accommodate for said update.

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

# Description Implements the Vat along with some test recipes # Todo  - [ ] Custom processing widget, this is not made since the widgets are to be rewrited for 1.19.4 if I recall correctly. - [ ] Custom processing widget for the JEI integration. - [x] Fluid tank update needs to be merged before this. - [ ] This code must be rebased to accommodate for said update. # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation

Rover656 commented

2023-06-27 22:29:43 +00:00

(Migrated from github.com)

Hey; are you still keen to work on this PR with us? Thanks!

albinaask commented

2023-07-02 16:04:59 +00:00

(Migrated from github.com)

Hey; are you still keen to work on this PR with us? Thanks!

Yes. I'd very much like to continue working on it. Life has come in between I'm afraid and hope to come back to it before the end of the summer hopefully. I really like the modding community and what EnderIO is becoming, so defiantly still keen even though time is at a premium at the moment in my life

> Hey; are you still keen to work on this PR with us? Thanks! Yes. I'd very much like to continue working on it. Life has come in between I'm afraid and hope to come back to it before the end of the summer hopefully. I really like the modding community and what EnderIO is becoming, so defiantly still keen even though time is at a premium at the moment in my life

❤️ 1

Rover656 commented

2023-07-02 20:44:32 +00:00

(Migrated from github.com)

No worries, no pressure at all!

Rover656 commented

2023-08-16 23:14:48 +00:00

(Migrated from github.com)

We're going to go ahead and close this. The vat might see some changes in direction and this PR is also really outdated at this point.
Thanks for your work on this though, feel free to come back to the Discord and chat with us if when you're free :)

We're going to go ahead and close this. The vat might see some changes in direction and this PR is also really outdated at this point. Thanks for your work on this though, feel free to come back to the Discord and chat with us if when you're free :)