Team-EnderIO/EnderIO
1
0
Fork 0
Code Issues 114 Pull requests 13 Projects Releases 79 Packages Wiki Activity Actions

Code Cleaning #165

Merged
Rover656 merged 35 commits from chore/120-cleaning into dev/1.20.1 2023-07-04 21:55:06 +00:00
Conversation 6 Commits 35 Files changed 257 +1281 -1213
Rover656 commented 2023-06-27 22:21:40 +00:00 (Migrated from github.com)
Copy link

Description

This is a fairly sizeable changelist of some changes to improve code health.
I'm trying to make one commit per big change to try and make it easy to follow.

Only big breaking change here is the removal of INamedNBTSerializable. I've removed it in favor of having explicit serialized names.

Todo

  • Finish standardisation of NBT keys
  • Move some keys from EIONBTKeys to CoreNBTKeys.
  • Move slot access and inventory layout stuff to core. Leaving for later, its more entangled than I had thought.
  • Review lang values (not keys, that is a future task)

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
# Description This is a fairly sizeable changelist of some changes to improve code health. I'm trying to make one commit per big change to try and make it easy to follow. Only big breaking change here is the removal of INamedNBTSerializable. I've removed it in favor of having explicit serialized names. # Todo <!-- Remove this section if you're submitting an already-complete PR --> - [x] Finish standardisation of NBT keys - [x] Move some keys from EIONBTKeys to CoreNBTKeys. - [x] ~~Move slot access and inventory layout stuff to core.~~ Leaving for later, its more entangled than I had thought. - [x] Review lang values (not keys, that is a future task) # Checklist: - [ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation <!-- Thanks to: https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ for the building blocks of this template -->
ferriarnus commented 2023-06-28 06:12:38 +00:00 (Migrated from github.com)
Copy link

Maybe you could also look into the "range" of machines, as right now it's not unified. All of these methods should probably be in the base machine class

Maybe you could also look into the "range" of machines, as right now it's not unified. All of these methods should probably be in the base machine class
Rover656 commented 2023-06-28 06:46:05 +00:00 (Migrated from github.com)
Copy link

Maybe you could also look into the "range" of machines, as right now it's not unified. All of these methods should probably be in the base machine class

I'll take note of this as I have plans to review some machines stuff in my next PR :)

> Maybe you could also look into the "range" of machines, as right now it's not unified. All of these methods should probably be in the base machine class I'll take note of this as I have plans to review some machines stuff in my next PR :)
Rover656 commented 2023-06-28 19:36:31 +00:00 (Migrated from github.com)
Copy link

Once #167 is merged, I can finish the NBT key stuff and this will be ready to merge. For now opening for initial review.

Once #167 is merged, I can finish the NBT key stuff and this will be ready to merge. For now opening for initial review.
ferriarnus (Migrated from github.com) reviewed 2023-07-03 19:29:59 +00:00
src/core/java/com/enderio/core/common/recipes/OutputStack.java
@ -73,4 +79,4 @@
* Write to NBT.
*/
public CompoundTag serializeNBT() {
CompoundTag tag = new CompoundTag();
ferriarnus (Migrated from github.com) commented 2023-07-03 19:12:44 +00:00
Copy link

Why is this not in core?

Why is this not in core?
src/main/java/com/enderio/base/common/item/tool/PoweredToggledItem.java
ferriarnus (Migrated from github.com) commented 2023-07-03 19:27:39 +00:00
Copy link

why added here?

why added here?
src/main/java/com/enderio/base/common/item/tool/PoweredToggledItem.java
ferriarnus (Migrated from github.com) commented 2023-07-03 19:27:49 +00:00
Copy link

why added here?

why added here?
src/main/java/com/enderio/base/common/item/tool/SoulVialItem.java
ferriarnus (Migrated from github.com) commented 2023-07-03 19:28:07 +00:00
Copy link

why added here?

why added here?
Rover656 (Migrated from github.com) reviewed 2023-07-03 19:31:46 +00:00
src/core/java/com/enderio/core/common/recipes/OutputStack.java
@ -73,4 +79,4 @@
* Write to NBT.
*/
public CompoundTag serializeNBT() {
CompoundTag tag = new CompoundTag();
Rover656 (Migrated from github.com) commented 2023-07-03 19:31:45 +00:00
Copy link

Good spot

Good spot
justliliandev (Migrated from github.com) reviewed 2023-07-04 21:53:52 +00:00
gradle.properties
@ -18,9 +18,8 @@ forge_version_range=[47.0.19,)
# Old Parchment: mappings_channel=parchment_previous, mappings_version=yyyy.mm.dd, previous_minecraft_version=1.x.x
justliliandev (Migrated from github.com) commented 2023-07-04 20:16:40 +00:00
Copy link

remove line, don't comment it out

remove line, don't comment it out
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Area-Assets

   
Area-Backend

Backend work not usually visible to players.

  
Area-Conduits

Everything involving conduits

  
Area-Datapacks

   
Area-Lang

   
Area-Mod Compat

   
Area-Parity

1.12.2 missing features

  
Area-Rendering

Rendering code, might be shaders specific or general.

  
Good first issue

   
MC-1.19.2

   
MC-1.20.1

   
MC-1.20.4

   
MC-1.20.6

   
MC-1.21

   
MC-1.21.1

   
Modtoberfest

   
P-0-High

High priority, crash/breaking.

  
P-1-Medium

Medium priority. Potentially deleting items or breaking functionality.

  
P-2-Low

Low priority. Not hurting anyone, just annoying.

  
Status-Awaiting Response

Waiting for OP to respond

  
Status-Behind-Flag

This change is available but is placed behind a feature flag.

  
Status-Blocked

Blocked by a specific issue or protocol.

  
Status-Cannot Reproduce

   
Status-Duplicate

This issue or pull request already exists

  
Status-Help Wanted

We need some help to try and track this thing down..

  
Status-Incomplete Report

   
Status-Invalid

This doesn't seem right

  
Status-Needs LTS Backport

Fixed in latest but requires LTS backport.

  
Status-Needs Updating

Needs updating to a newer Minecraft version.

  
Status-Stale

This may not be updated by the OP any further.

  
Status-To Implement

   
Status-Triage

A Triage Member should take a look at this

  
Status-Wontfix

This will not be worked on

  
Status-Wontmerge

This PR won't be merged, but is left now for reference of ongoing or future works.

  
Type-Backport

   
Type-Bug

There is a problem.

  
Type-Documentation

Improvements or additions to documentation

  
Type-Enhancement

New feature or enhancement to existing feature.

  
Type-Question

Further information is requested

  
Type-RFC

Request for comments.

  
Type-Suggestion
No labels
Area-Assets
Area-Backend
Area-Conduits
Area-Datapacks
Area-Lang
Area-Mod Compat
Area-Parity
Area-Rendering
Good first issue
MC-1.19.2
MC-1.20.1
MC-1.20.4
MC-1.20.6
MC-1.21
MC-1.21.1
Modtoberfest
P-0-High
P-1-Medium
P-2-Low
Status-Awaiting Response
Status-Behind-Flag
Status-Blocked
Status-Cannot Reproduce
Status-Duplicate
Status-Help Wanted
Status-Incomplete Report
Status-Invalid
Status-Needs LTS Backport
Status-Needs Updating
Status-Stale
Status-To Implement
Status-Triage
Status-Wontfix
Status-Wontmerge
Type-Backport
Type-Bug
Type-Documentation
Type-Enhancement
Type-Question
Type-RFC
Type-Suggestion
Milestone
Clear milestone
No items
No milestone
First Alpha Release (v6.0)
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#165
No description provided.
Delete branch "chore/120-cleaning"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?