is this a bob ross reference? #167

2023-06-28T06:33:49Z

justliliandev commented

2023-06-28 06:33:49 +00:00

(Migrated from github.com)

Description

Adds the painting machine, Painted Blocks worked before, this is just a way to obtain them.
Currently this doesn't have a proper front model, I stole the sag mill one

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

# Description Adds the painting machine, Painted Blocks worked before, this is just a way to obtain them. Currently this doesn't have a proper front model, I stole the sag mill one # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation

😆 1

Rover656 commented

2023-06-28 11:37:30 +00:00

(Migrated from github.com)

I'll try to get this reviewed for you later tonight

Rover656 (Migrated from github.com) requested changes

2023-06-28 17:13:11 +00:00

Rover656 (Migrated from github.com) left a comment

Just a couple of things; but looking good!

src/machines/java/com/enderio/machines/common/recipe/PaintingRecipe.java

					
				@ -0,0 +1,136 @@

				package com.enderio.machines.common.recipe;

Rover656 (Migrated from github.com) commented

2023-06-28 17:05:54 +00:00

Is there any way at all we could not pass the entire block entity in the container?

Rover656 (Migrated from github.com) commented

2023-06-28 17:06:18 +00:00

Could we maybe drive this from config files?

src/main/java/com/enderio/EnderIO.java

					
				@ -95,3 +97,4 @@

				        EIOEntities.register();

				        // Run datagen after registrate is finished.

				        IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();

Rover656 (Migrated from github.com) commented

2023-06-28 17:10:10 +00:00

I'm in two minds here:

Either we should merge all of these down into a single init class again
-or-
we could further separate these out into more divided chunks to make them easier to navigate.

I'm happy for whichever as long as we're consistent :)

I'm in two minds here: Either we should merge all of these down into a single init class again -or- we could further separate these out into more divided chunks to make them easier to navigate. I'm happy for whichever as long as we're consistent :)

justliliandev (Migrated from github.com) reviewed

2023-06-28 17:23:08 +00:00

src/machines/java/com/enderio/machines/common/recipe/PaintingRecipe.java

					
				@ -0,0 +1,136 @@

				package com.enderio.machines.common.recipe;

justliliandev (Migrated from github.com) commented

2023-06-28 17:23:07 +00:00

yes, I just copied the sag mill, but I don't need it

justliliandev (Migrated from github.com) reviewed

2023-06-28 17:23:35 +00:00

src/machines/java/com/enderio/machines/common/recipe/PaintingRecipe.java

					
				@ -0,0 +1,136 @@

				package com.enderio.machines.common.recipe;

justliliandev (Migrated from github.com) commented

2023-06-28 17:23:35 +00:00

I think the config file would become cluttered easily if every machine got an entry

justliliandev (Migrated from github.com) reviewed

2023-06-28 17:25:03 +00:00

src/main/java/com/enderio/EnderIO.java

					
				@ -95,3 +97,4 @@

				        EIOEntities.register();

				        // Run datagen after registrate is finished.

				        IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();

justliliandev (Migrated from github.com) commented

2023-06-28 17:25:03 +00:00

oh no, work

Rover656 (Migrated from github.com) reviewed

2023-06-28 17:25:05 +00:00

src/machines/java/com/enderio/machines/common/recipe/PaintingRecipe.java

					
				@ -0,0 +1,136 @@

				package com.enderio.machines.common.recipe;

Rover656 (Migrated from github.com) commented

2023-06-28 17:25:05 +00:00

That's fair, but its still a really nice way of being able to configure everything, especially when it comes to balance; means we don't have to dig into a massive number of files to find everything

Rover656 (Migrated from github.com) approved these changes

2023-07-03 06:23:24 +00:00

Rover656 (Migrated from github.com) left a comment

This is the only other thing I can see at the minute :) Thanks

src/main/java/com/enderio/EnderIO.java

					
				@ -99,6 +102,10 @@ public class EnderIO {

				        modEventBus.addListener(SoulVialItem::onCommonSetup);

				        IntegrationManager.addIntegration(EnderIOSelfIntegration.INSTANCE);

				        new UseGliderTrigger().register();

				        new PaintingTrigger().register();

Rover656 (Migrated from github.com) commented

2023-07-03 06:22:33 +00:00

Can we move this up with the others, drop the Decor comment and maybe call BaseNetwork EIONetwork for consistency?

ferriarnus (Migrated from github.com) reviewed

2023-07-03 12:02:09 +00:00

src/machines/java/com/enderio/machines/client/gui/screen/PaintingMachineScreen.java

					
				@ -0,0 +1,44 @@

				package com.enderio.machines.client.gui.screen;

ferriarnus (Migrated from github.com) commented

2023-07-03 12:02:09 +00:00

Make the painter use the new capacitor tooltip energy widget

         addRenderableOnly(new CapacitorEnergyWidget(this, getMenu().getBlockEntity()::getEnergyStorage, getMenu().getBlockEntity()::isCapacitorInstalled, 16 + leftPos, 14 + topPos, 9, 42));

Make the painter use the new capacitor tooltip energy widget ```suggestion addRenderableOnly(new CapacitorEnergyWidget(this, getMenu().getBlockEntity()::getEnergyStorage, getMenu().getBlockEntity()::isCapacitorInstalled, 16 + leftPos, 14 + topPos, 9, 42)); ```