make itemstack capabilities #174

Merged
ferriarnus merged 4 commits from itemstackcaps into dev/1.20.1 2023-07-01 19:23:01 +00:00
ferriarnus commented 2023-07-01 11:52:03 +00:00 (Migrated from github.com)

These capabilities directly store their data in the itemstack nbt.

Description

The caps on itemstacks aren't synced in multiplayer, so we need to store and send them ourselves. For this we make use of the nbt data on the itemstack directly.

Fixes issue(s): #169

Todo

  • Replace strings in NBT with constants
  • Verify multiplayer worlds

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
These capabilities directly store their data in the itemstack nbt. # Description The caps on itemstacks aren't synced in multiplayer, so we need to store and send them ourselves. For this we make use of the nbt data on the itemstack directly. Fixes issue(s): #169 # Todo <!-- Remove this section if you're submitting an already-complete PR --> - [ ] Replace strings in NBT with constants - [x] Verify multiplayer worlds # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation <!-- Thanks to: https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ for the building blocks of this template -->
Rover656 (Migrated from github.com) approved these changes 2023-07-01 12:06:21 +00:00
Rover656 (Migrated from github.com) left a comment

This all looks good, thanks Ferri!

This all looks good, thanks Ferri!
Rover656 commented 2023-07-01 12:06:43 +00:00 (Migrated from github.com)

Once you've verified this works in multiplayer, feel free to merge. I'll do the NBT stuff in #165 :)

Once you've verified this works in multiplayer, feel free to merge. I'll do the NBT stuff in #165 :)
Sign in to join this conversation.
No reviewers
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#174
No description provided.