Fix multiplayer data sync #193

Merged

Rover656 merged 6 commits from fix/data-slots into dev/1.20.1

2023-07-05 19:37:27 +00:00

Rover656 commented

2023-07-02 18:52:24 +00:00

(Migrated from github.com)

Description

Removed caching of previous NBT values, this was causing multiplayer to only serve data to a single player.
Added a versioned data slot. Data that is two-sided now needs to be versioned due to the removal of caching.

It would have been nice to have data caching for this purpose however it was necessary to ensure proper multiplayer function.
If we would like, I would be happy to convert the system from NBT to raw network buffering to try and improve bandwidth consumption due to this change.

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

# Description - Removed caching of previous NBT values, this was causing multiplayer to only serve data to a single player. - Added a versioned data slot. Data that is two-sided now needs to be versioned due to the removal of caching. It would have been nice to have data caching for this purpose however it was necessary to ensure proper multiplayer function. If we would like, I would be happy to convert the system from NBT to raw network buffering to try and improve bandwidth consumption due to this change. # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation

justliliandev (Migrated from github.com) approved these changes

2023-07-05 18:50:39 +00:00