Team-EnderIO/EnderIO

Fix grindstone and also mixin refmaps lmao #203

Merged

Rover656 merged 1 commit from fix/grindstone into dev/1.20.1

2023-07-05 20:57:47 +00:00

Rover656 commented

2023-07-03 21:03:46 +00:00

(Migrated from github.com)

Description

Fixed grindstone with a dirty mixin, also fixed refmaps!

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

# Description Fixed grindstone with a dirty mixin, also fixed refmaps! # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation

ferriarnus (Migrated from github.com) requested changes

2023-07-03 21:07:30 +00:00

src/main/java/com/enderio/base/mixin/ItemStackMixin.java

					
				@ -0,0 +12,4 @@

				    @Shadow()

				    public abstract Item getItem();

				    @Override

ferriarnus (Migrated from github.com) commented

2023-07-03 21:06:50 +00:00

Don't override, inject instead. No one should make a new itemstack class, but it is still better imo.

Don't override, inject instead. No one should make a new itemstack class, but it is still better imo.

Rover656 (Migrated from github.com) reviewed

2023-07-03 21:33:00 +00:00

src/main/java/com/enderio/base/mixin/ItemStackMixin.java

					
				@ -0,0 +12,4 @@

				    @Shadow()

				    public abstract Item getItem();

				    @Override

Rover656 (Migrated from github.com) commented

2023-07-03 21:33:00 +00:00

Ah good idea, ill get that tomorrow

Ah good idea, ill get that tomorrow

ferriarnus (Migrated from github.com) reviewed

2023-07-05 09:55:40 +00:00

src/main/java/com/enderio/base/mixin/ItemStackMixin.java

					
				@ -0,0 +12,4 @@

				    @Shadow()

				    public abstract Item getItem();

				    @Override

ferriarnus (Migrated from github.com) commented

2023-07-05 09:55:39 +00:00

It might not be possible because it's a default method. An override would be good instead.

It might not be possible because it's a default method. An override would be good instead.

Sign in to join this conversation.

No reviewers

No labels

Area-Mod Compat

Good first issue

Status-Awaiting Response

Status-Behind-Flag

Status-Cannot Reproduce

Status-Duplicate

Status-Help Wanted

Status-Incomplete Report

Status-Needs LTS Backport

Status-Needs Updating

Status-To Implement

Status-Wontmerge

Type-Documentation

Type-Enhancement

Type-Suggestion

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#203

No description provided.