Initial Power Generators (and code cleaning) #26

2022-05-23T15:50:50Z

Rover656 commented

2022-05-23 15:50:50 +00:00

(Migrated from github.com)

Description

Currently has none of the powergen works, this is for tracking as I'm also doing a lot of under-the-hood tweaks.

Current changes:

Moved a bunch of common classes and interfaces that can operate independently to an api ~~jar~~ package.
Cleaned a bunch of the underlying machine classes.
Updates to the latest RB forge.
Adds mekanism for easy testing of resource transfer.
Cleaned more of the custom recipe implementation.
Implements the new capacitor system, see #35

Todo

Finish tidying the underlying machine implementation
Temporary creative power block
Stirling generator implementation
Stirling generator models/textures

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

# Description Currently has none of the powergen works, this is for tracking as I'm also doing a lot of under-the-hood tweaks. Current changes: - Moved a bunch of common classes and interfaces that can operate independently to an api ~~jar~~ package. - Cleaned a bunch of the underlying machine classes. - Updates to the latest RB forge. - Adds mekanism for easy testing of resource transfer. - Cleaned more of the custom recipe implementation. - Implements the new capacitor system, see #35 # Todo - [x] Finish tidying the underlying machine implementation - [x] Temporary creative power block - [x] Stirling generator implementation - [x] Stirling generator models/textures # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation

ferriarnus (Migrated from github.com) reviewed

2022-05-25 18:58:58 +00:00

enderio-machines/src/main/java/com/enderio/machines/common/energy/EnergyTransferMode.java

					
				@ -0,0 +3,4 @@

				public enum EnergyTransferMode {

				    None,

				    Insert,

				    Extract

ferriarnus (Migrated from github.com) commented

2022-05-25 18:58:58 +00:00

No both?

Rover656 (Migrated from github.com) reviewed

2022-05-25 19:00:21 +00:00

enderio-machines/src/main/java/com/enderio/machines/common/energy/EnergyTransferMode.java

					
				@ -0,0 +3,4 @@

				public enum EnergyTransferMode {

				    None,

				    Insert,

				    Extract

Rover656 (Migrated from github.com) commented

2022-05-25 19:00:20 +00:00

Not taking into account individual sides, it'd only receive or send power at any given time. This is an old enum that's planned to be replaced in my energy rework PR.

ferriarnus (Migrated from github.com) reviewed

2022-05-25 19:00:45 +00:00

enderio-machines/src/main/java/com/enderio/machines/common/blockentity/base/MachineBlockEntity.java

ferriarnus (Migrated from github.com) commented

2022-05-25 19:00:45 +00:00

What do you mean? Since for example the vacuum chest don't have side control, but still output items. Same for the xp vacuum. But we could also just give them side control

Rover656 (Migrated from github.com) reviewed

2022-05-25 19:02:02 +00:00

enderio-machines/src/main/java/com/enderio/machines/common/blockentity/base/MachineBlockEntity.java

Rover656 (Migrated from github.com) commented

2022-05-25 19:02:02 +00:00

Thats's a good argument, yeah. At the time I just left it as a todo as it needs to be discussed. The entire IO configuration system could do with a once-over with documentation so its clearer.