Fix conduit shape and connector type #269

Merged

ferriarnus merged 3 commits from conduit-shape into dev/1.20.1

2023-07-11 07:48:00 +00:00

ferriarnus commented

2023-07-09 14:26:14 +00:00

(Migrated from github.com)

Description

properly links the conduit type to the connector.

Fixes issue(s): #253, #254 (partial),

Todo

Things that are yet to be completed for this PR to no longer be a draft.

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

# Description properly links the conduit type to the connector. Fixes issue(s): #253, #254 (partial), # Todo  - [ ] Things that are yet to be completed for this PR to no longer be a draft. # Checklist: - [ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation

justliliandev (Migrated from github.com) approved these changes

2023-07-09 15:40:00 +00:00

Rover656 commented

2023-07-09 18:40:26 +00:00

(Migrated from github.com)

Ferri, is this ready for merge? If so, should this leave #254 open?