Loot Tweaks #273

2023-07-09T18:32:39Z

Rover656 commented

2023-07-09 18:32:39 +00:00

(Migrated from github.com)

Description

Stopped "Fixed" capacitor modifiers from being generated as loot.
Fixed loot capacitors not storing stats on multiplayer (Breaking: old loot capacitors will reset).
Loot capacitors have a small chance of generating with more than one modifier.

Now includes near enough similar chest loot entries for the overworld, will need another pass when we have more content, but its enough to keep us going.

Todo

Confirm loot changes
Add other loot entries
Spawn loot in more places

Closes #238

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

# Description - Stopped "Fixed" capacitor modifiers from being generated as loot. - Fixed loot capacitors not storing stats on multiplayer (Breaking: old loot capacitors will reset). - Loot capacitors have a small chance of generating with more than one modifier. Now includes near enough similar chest loot entries for the overworld, will need another pass when we have more content, but its enough to keep us going. # Todo - [x] Confirm loot changes - [x] Add other loot entries - [x] Spawn loot in more places Closes #238 # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation

Rover656 (Migrated from github.com) reviewed

2023-07-09 22:07:51 +00:00

Rover656 (Migrated from github.com) left a comment

Also going to look at adding the other missing loot tables entries from 1.12.2

src/main/java/com/enderio/base/common/loot/CapacitorLootModifier.java

Rover656 (Migrated from github.com) commented

2023-07-09 22:06:17 +00:00

Just noticed that these had different min/max. Might be worth either keeping it within the min/max or having another parameter in the loot modifier

justliliandev (Migrated from github.com) reviewed

2023-07-29 21:59:42 +00:00

src/main/java/com/enderio/base/common/capacitor/CapacitorUtil.java

					
				@ -79,6 +79,6 @@ public class CapacitorUtil {

				    }

justliliandev (Migrated from github.com) commented

2023-07-29 21:59:42 +00:00

use second array for valid modifiers

Sign in to join this conversation.

No reviewers

No labels

Status-Awaiting Response

Status-Behind-Flag

Status-Blocked

Status-Cannot Reproduce

Status-Duplicate

Status-Help Wanted

Status-Incomplete Report

Status-Invalid

Status-Needs LTS Backport

Status-Needs Updating

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#273

Rows
Columns