Fix keep inventory behavior #321

Merged
ferriarnus merged 1 commit from keepinv-fix into dev/1.20.1 2023-07-20 19:01:32 +00:00
ferriarnus commented 2023-07-19 23:27:21 +00:00 (Migrated from github.com)

Description

Fixes the keep inventory behavior by making the soulbound enchantment not always work. This is somewhat of a temp fix, as the soulbound enchantment might get reworked in the future

Closes #250

Todo

  • Fixed, hopefully?

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.
# Description Fixes the keep inventory behavior by making the soulbound enchantment not always work. This is somewhat of a temp fix, as the soulbound enchantment might get reworked in the future Closes #250 <!-- Follow this exact pattern for every issue you've fixed to help GitHub automatically link your PR to the relevant issues --> <!-- Remove this section if you're submitting an already-complete PR --> # Todo - [x] Fixed, hopefully? <!-- For drafts, fill this in as you go; if you are leaving draft, make sure these are all done --> # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [x] I have performed a self-review of my own code. - [x] I have commented my code in areas it may be challenging to understand. <!-- (Although we prefer code that is readable instead of over-commented) --> - [x] I have made corresponding changes to the documentation. - [x] My changes are ready for review from a contributor. <!-- Thanks to: https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ for the building blocks of this template -->
Rover656 (Migrated from github.com) approved these changes 2023-07-20 19:00:27 +00:00
Rover656 (Migrated from github.com) left a comment

Looks goof for now!

Looks goof for now!
Rover656 commented 2023-07-20 19:00:38 +00:00 (Migrated from github.com)

Oops, typo; looks good :P

Oops, typo; looks good :P
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#321
No description provided.