Team-EnderIO/EnderIO
1
0
Fork 0
Code Issues 114 Pull requests 13 Projects Releases 79 Packages Wiki Activity Actions

Remove Serialization from MultiCapabilityProvider #322

Merged
ferriarnus merged 2 commits from Multicap-nonserialize into dev/1.20.1 2023-07-20 19:05:01 +00:00
Conversation 2 Commits 2 Files changed 11 +16 -53
ferriarnus commented 2023-07-20 14:20:43 +00:00 (Migrated from github.com)
Copy link

Description

Since we serialize ourselves directly to nbt, we no longer need a serializable provider. This solves an issue where the capacitors had not needed nbt data, stopping the autocrafting.

As a side note this change probably broke our current darksteel tools impl. This Impl however was most likely broken on servers, and thus needs a rework.

Closes #315

Todo

  • Hopefully nothing.

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.
# Description Since we serialize ourselves directly to nbt, we no longer need a serializable provider. This solves an issue where the capacitors had not needed nbt data, stopping the autocrafting. As a side note this change probably broke our current darksteel tools impl. This Impl however was most likely broken on servers, and thus needs a rework. Closes #315 <!-- Follow this exact pattern for every issue you've fixed to help GitHub automatically link your PR to the relevant issues --> <!-- Remove this section if you're submitting an already-complete PR --> # Todo - [ ] Hopefully nothing. <!-- For drafts, fill this in as you go; if you are leaving draft, make sure these are all done --> # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [x] I have performed a self-review of my own code. - [x] I have commented my code in areas it may be challenging to understand. <!-- (Although we prefer code that is readable instead of over-commented) --> - [x] I have made corresponding changes to the documentation. - [x] My changes are ready for review from a contributor. <!-- Thanks to: https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ for the building blocks of this template -->
Rover656 (Migrated from github.com) requested changes 2023-07-20 18:59:48 +00:00
Rover656 (Migrated from github.com) left a comment
Copy link

Looks great, just a quick naming change please! Thanks!!

Looks great, just a quick naming change please! Thanks!!
src/api/java/com/enderio/api/capability/MultiCapabilityProvider.java
@ -14,26 +11,19 @@ import java.util.HashMap;
import java.util.Map;
Rover656 (Migrated from github.com) commented 2023-07-20 18:59:23 +00:00
Copy link

This can just be called add now imo.

This can just be called `add` now imo.
ferriarnus (Migrated from github.com) reviewed 2023-07-20 19:02:37 +00:00
src/api/java/com/enderio/api/capability/MultiCapabilityProvider.java
@ -14,26 +11,19 @@ import java.util.HashMap;
import java.util.Map;
ferriarnus (Migrated from github.com) commented 2023-07-20 19:02:37 +00:00
Copy link

Makes sense, I'll change it.

Makes sense, I'll change it.
Sign in to join this conversation.
Reviewers
No reviewers
Rover656
Labels
Clear labels   
Area-Assets

   
Area-Backend

Backend work not usually visible to players.

  
Area-Conduits

Everything involving conduits

  
Area-Datapacks

   
Area-Lang

   
Area-Mod Compat

   
Area-Parity

1.12.2 missing features

  
Area-Rendering

Rendering code, might be shaders specific or general.

  
Good first issue

   
MC-1.19.2

   
MC-1.20.1

   
MC-1.20.4

   
MC-1.20.6

   
MC-1.21

   
MC-1.21.1

   
Modtoberfest

   
P-0-High

High priority, crash/breaking.

  
P-1-Medium

Medium priority. Potentially deleting items or breaking functionality.

  
P-2-Low

Low priority. Not hurting anyone, just annoying.

  
Status-Awaiting Response

Waiting for OP to respond

  
Status-Behind-Flag

This change is available but is placed behind a feature flag.

  
Status-Blocked

Blocked by a specific issue or protocol.

  
Status-Cannot Reproduce

   
Status-Duplicate

This issue or pull request already exists

  
Status-Help Wanted

We need some help to try and track this thing down..

  
Status-Incomplete Report

   
Status-Invalid

This doesn't seem right

  
Status-Needs LTS Backport

Fixed in latest but requires LTS backport.

  
Status-Needs Updating

Needs updating to a newer Minecraft version.

  
Status-Stale

This may not be updated by the OP any further.

  
Status-To Implement

   
Status-Triage

A Triage Member should take a look at this

  
Status-Wontfix

This will not be worked on

  
Status-Wontmerge

This PR won't be merged, but is left now for reference of ongoing or future works.

  
Type-Backport

   
Type-Bug

There is a problem.

  
Type-Documentation

Improvements or additions to documentation

  
Type-Enhancement

New feature or enhancement to existing feature.

  
Type-Question

Further information is requested

  
Type-RFC

Request for comments.

  
Type-Suggestion
No labels
Area-Assets
Area-Backend
Area-Conduits
Area-Datapacks
Area-Lang
Area-Mod Compat
Area-Parity
Area-Rendering
Good first issue
MC-1.19.2
MC-1.20.1
MC-1.20.4
MC-1.20.6
MC-1.21
MC-1.21.1
Modtoberfest
P-0-High
P-1-Medium
P-2-Low
Status-Awaiting Response
Status-Behind-Flag
Status-Blocked
Status-Cannot Reproduce
Status-Duplicate
Status-Help Wanted
Status-Incomplete Report
Status-Invalid
Status-Needs LTS Backport
Status-Needs Updating
Status-Stale
Status-To Implement
Status-Triage
Status-Wontfix
Status-Wontmerge
Type-Backport
Type-Bug
Type-Documentation
Type-Enhancement
Type-Question
Type-RFC
Type-Suggestion
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#322
No description provided.
Delete branch "Multicap-nonserialize"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?