Team-EnderIO/EnderIO

Reduce lang duplication by reusing glass names #348

Merged

Rover656 merged 2 commits from feature/smaller-lang into dev/1.20.1

2023-07-27 17:41:24 +00:00

Rover656 commented

2023-07-25 18:49:03 +00:00

(Migrated from github.com)

Description

Reduces the amount of noise in the lang file by reusing keys for the different types of glass.

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
I have performed a self-review of my own code.
I have commented my code in areas it may be challenging to understand.
I have made corresponding changes to the documentation.
My changes are ready for review from a contributor.

# Description Reduces the amount of noise in the lang file by reusing keys for the different types of glass.  # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [x] I have performed a self-review of my own code. - [x] I have commented my code in areas it may be challenging to understand.  - [x] I have made corresponding changes to the documentation. - [x] My changes are ready for review from a contributor.

justliliandev (Migrated from github.com) reviewed

2023-07-25 18:49:03 +00:00

justliliandev (Migrated from github.com) reviewed

2023-07-26 17:01:26 +00:00

src/main/java/com/enderio/base/common/block/glass/FusedQuartzBlock.java

					
				@ -23,12 +26,23 @@ public class FusedQuartzBlock extends AbstractGlassBlock {

				    private final GlassCollisionPredicate collisionPredicate;

				    private final GlassLighting glassLighting;

justliliandev (Migrated from github.com) commented

2023-07-26 17:00:28 +00:00

could you precompute the description id in the constructor?

could you precompute the description id in the constructor?

Rover656 (Migrated from github.com) reviewed

2023-07-26 17:02:02 +00:00

src/main/java/com/enderio/base/common/block/glass/FusedQuartzBlock.java

					
				@ -23,12 +26,23 @@ public class FusedQuartzBlock extends AbstractGlassBlock {

				    private final GlassCollisionPredicate collisionPredicate;

				    private final GlassLighting glassLighting;

Rover656 (Migrated from github.com) commented

2023-07-26 17:02:02 +00:00

Yep can do, only did this as its how vanilla structured it :)

Yep can do, only did this as its how vanilla structured it :)

justliliandev (Migrated from github.com) reviewed

2023-07-26 17:05:27 +00:00

src/main/java/com/enderio/base/common/block/glass/FusedQuartzBlock.java

					
				@ -23,12 +26,23 @@ public class FusedQuartzBlock extends AbstractGlassBlock {

				    private final GlassCollisionPredicate collisionPredicate;

				    private final GlassLighting glassLighting;

justliliandev (Migrated from github.com) commented

2023-07-26 17:05:27 +00:00

vanilla is stupid

vanilla is stupid

Sign in to join this conversation.

No reviewers

No labels

Area-Mod Compat

Good first issue

Status-Awaiting Response

Status-Behind-Flag

Status-Cannot Reproduce

Status-Duplicate

Status-Help Wanted

Status-Incomplete Report

Status-Needs LTS Backport

Status-Needs Updating

Status-To Implement

Status-Wontmerge

Type-Documentation

Type-Enhancement

Type-Suggestion

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#348

No description provided.