Use Enchantment Descriptions. #414

Merged

Rover656 merged 3 commits from feature/enchantment-descriptions into dev/1.20.1

2023-08-04 19:15:00 +00:00

Rover656 commented

2023-08-02 21:46:40 +00:00

(Migrated from github.com)

Description

Uses the enchantment descriptions mod instead of rolling our own.
Continues to display the tool types for the withering enchantments.
Also changes our tooltips to aqua to make them clearer and removes shift to show on capacitors, as you will more likely want to see the values than not.

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
I have performed a self-review of my own code.
I have commented my code in areas it may be challenging to understand.
I have made corresponding changes to the documentation.
My changes are ready for review from a contributor.

# Description Uses the enchantment descriptions mod instead of rolling our own. Continues to display the tool types for the withering enchantments. Also changes our tooltips to aqua to make them clearer and removes shift to show on capacitors, as you will more likely want to see the values than not. ![image](https://github.com/Team-EnderIO/EnderIO/assets/20544390/1fc69548-ec9e-4313-811f-c6c4ebe89cff) ![image](https://github.com/Team-EnderIO/EnderIO/assets/20544390/ef24aa7a-a7e5-4f8a-9d2c-35b9bb561dec) ![image](https://github.com/Team-EnderIO/EnderIO/assets/20544390/ec1cd84e-c45c-4b8e-a7ea-50be3bafae41)  # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [x] I have performed a self-review of my own code. - [x] I have commented my code in areas it may be challenging to understand.  - [x] I have made corresponding changes to the documentation. - [x] My changes are ready for review from a contributor.

justliliandev (Migrated from github.com) reviewed

2023-08-03 21:11:38 +00:00

justliliandev (Migrated from github.com) left a comment

looks good, if we want to merge the Wither Enchantments we might want to do that here too

ferriarnus commented

2023-08-04 16:29:24 +00:00

(Migrated from github.com)

We could, but I think vanilla doesn't have a combined category for arrows and bolts. Though looking at the code I messed up and bolts aren't actually bolts, they also use arrow...

justliliandev (Migrated from github.com) approved these changes

2023-08-04 19:14:51 +00:00