Team-EnderIO/EnderIO
1
0
Fork 0
Code Issues 114 Pull requests 13 Projects Releases 79 Packages Wiki Activity Actions

Rebalance energy values. First draft/attempt. #419

Merged
Rover656 merged 12 commits from collaboration/powerbalancing into dev/1.20.1 2023-08-04 20:05:00 +00:00
Conversation 5 Commits 12 Files changed 202 +461 -963
Rover656 commented 2023-08-03 18:51:20 +00:00 (Migrated from github.com)
Copy link

Description

Rebalancing of energy values across the mod.
Edit(agnor): changing and renaming of solar panel tiers

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.
# Description Rebalancing of energy values across the mod. Edit(agnor): changing and renaming of solar panel tiers <!-- For drafts, fill this in as you go; if you are leaving draft, make sure these are all done --> # Checklist: - [ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [ ] I have performed a self-review of my own code. - [ ] I have commented my code in areas it may be challenging to understand. <!-- (Although we prefer code that is readable instead of over-commented) --> - [ ] I have made corresponding changes to the documentation. - [ ] My changes are ready for review from a contributor. <!-- Thanks to: https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ for the building blocks of this template -->
ferriarnus (Migrated from github.com) reviewed 2023-08-03 21:48:56 +00:00
src/machines/java/com/enderio/machines/common/init/MachineBlocks.java
ferriarnus (Migrated from github.com) commented 2023-08-03 21:48:56 +00:00
Copy link

Should we rename the solar tiers to match the new recipe/capacitor banks?

Should we rename the solar tiers to match the new recipe/capacitor banks?
justliliandev (Migrated from github.com) requested changes 2023-08-04 00:08:45 +00:00
build.gradle
@ -446,0 +446,4 @@
version_hash = "-" + "git rev-parse --short HEAD".execute().text.trim()
} catch (ignored) {
}
justliliandev (Migrated from github.com) commented 2023-08-03 22:43:54 +00:00
Copy link

??? I'm just going to trust you, lmao

??? I'm just going to trust you, lmao
src/generated/resources/data/enderio/eio_soul/spawner/minecraft_evoker.json
@ -1,5 +1,5 @@
{
justliliandev (Migrated from github.com) commented 2023-08-03 23:42:01 +00:00
Copy link

not expensive enough, maybe 400k?

not expensive enough, maybe 400k?
src/generated/resources/data/enderio/eio_soul/spawner/minecraft_iron_golem.json
@ -1,5 +1,5 @@
{
justliliandev (Migrated from github.com) commented 2023-08-03 23:41:06 +00:00
Copy link

not expensive enough, maybe 100k?

not expensive enough, maybe 100k?
src/generated/resources/data/enderio/eio_soul/spawner/minecraft_shulker.json
@ -1,5 +1,5 @@
{
justliliandev (Migrated from github.com) commented 2023-08-03 23:40:48 +00:00
Copy link

not expensive enough, maybe 200k?

not expensive enough, maybe 200k?
src/machines/java/com/enderio/machines/EIOMachines.java
justliliandev (Migrated from github.com) commented 2023-08-03 23:55:05 +00:00
Copy link

add todo to remove this at some point in beta/release

add todo to remove this at some point in beta/release
src/machines/java/com/enderio/machines/common/integrations/vanilla/VanillaAlloySmeltingRecipe.java
@ -35,12 +32,12 @@ public class VanillaAlloySmeltingRecipe extends AlloySmeltingRecipe {
@Override
public int getBaseEnergyCost() {
justliliandev (Migrated from github.com) commented 2023-08-04 00:06:39 +00:00
Copy link
        return getBaseEnergyCost() * container.getInputsTaken();
```suggestion return getBaseEnergyCost() * container.getInputsTaken(); ```
Rover656 (Migrated from github.com) reviewed 2023-08-04 06:29:24 +00:00
build.gradle
@ -446,0 +446,4 @@
version_hash = "-" + "git rev-parse --short HEAD".execute().text.trim()
} catch (ignored) {
}
Rover656 (Migrated from github.com) commented 2023-08-04 06:29:24 +00:00
Copy link

This means dev builds include the name of the branch (after the last /), it was so that we could differentiate between different dev builds off different places :)

This means dev builds include the name of the branch (after the last `/`), it was so that we could differentiate between different dev builds off different places :)
Rover656 (Migrated from github.com) reviewed 2023-08-04 19:17:56 +00:00
src/machines/java/com/enderio/machines/common/init/MachineBlocks.java
Rover656 (Migrated from github.com) commented 2023-08-04 19:17:56 +00:00
Copy link

What do you mean by this?

What do you mean by this?
justliliandev (Migrated from github.com) approved these changes 2023-08-04 19:59:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
justliliandev
Labels
Clear labels   
Area-Assets

   
Area-Backend

Backend work not usually visible to players.

  
Area-Conduits

Everything involving conduits

  
Area-Datapacks

   
Area-Lang

   
Area-Mod Compat

   
Area-Parity

1.12.2 missing features

  
Area-Rendering

Rendering code, might be shaders specific or general.

  
Good first issue

   
MC-1.19.2

   
MC-1.20.1

   
MC-1.20.4

   
MC-1.20.6

   
MC-1.21

   
MC-1.21.1

   
Modtoberfest

   
P-0-High

High priority, crash/breaking.

  
P-1-Medium

Medium priority. Potentially deleting items or breaking functionality.

  
P-2-Low

Low priority. Not hurting anyone, just annoying.

  
Status-Awaiting Response

Waiting for OP to respond

  
Status-Behind-Flag

This change is available but is placed behind a feature flag.

  
Status-Blocked

Blocked by a specific issue or protocol.

  
Status-Cannot Reproduce

   
Status-Duplicate

This issue or pull request already exists

  
Status-Help Wanted

We need some help to try and track this thing down..

  
Status-Incomplete Report

   
Status-Invalid

This doesn't seem right

  
Status-Needs LTS Backport

Fixed in latest but requires LTS backport.

  
Status-Needs Updating

Needs updating to a newer Minecraft version.

  
Status-Stale

This may not be updated by the OP any further.

  
Status-To Implement

   
Status-Triage

A Triage Member should take a look at this

  
Status-Wontfix

This will not be worked on

  
Status-Wontmerge

This PR won't be merged, but is left now for reference of ongoing or future works.

  
Type-Backport

   
Type-Bug

There is a problem.

  
Type-Documentation

Improvements or additions to documentation

  
Type-Enhancement

New feature or enhancement to existing feature.

  
Type-Question

Further information is requested

  
Type-RFC

Request for comments.

  
Type-Suggestion
No labels
Area-Assets
Area-Backend
Area-Conduits
Area-Datapacks
Area-Lang
Area-Mod Compat
Area-Parity
Area-Rendering
Good first issue
MC-1.19.2
MC-1.20.1
MC-1.20.4
MC-1.20.6
MC-1.21
MC-1.21.1
Modtoberfest
P-0-High
P-1-Medium
P-2-Low
Status-Awaiting Response
Status-Behind-Flag
Status-Blocked
Status-Cannot Reproduce
Status-Duplicate
Status-Help Wanted
Status-Incomplete Report
Status-Invalid
Status-Needs LTS Backport
Status-Needs Updating
Status-Stale
Status-To Implement
Status-Triage
Status-Wontfix
Status-Wontmerge
Type-Backport
Type-Bug
Type-Documentation
Type-Enhancement
Type-Question
Type-RFC
Type-Suggestion
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#419
No description provided.
Delete branch "collaboration/powerbalancing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?