Prevent item duplication by updating processing recipes in SAG Mill #616

Merged

Lapis256 merged 3 commits from fix/sag_mill_recipes into dev/1.20.1

2024-02-15 11:41:48 +00:00

Lapis256 commented

2024-02-12 16:52:52 +00:00

(Migrated from github.com)

Description

In the SAG Mill's processing recipes, an incorrect BonusType was set, allowing for potential item duplication.
To resolve this issue, I have updated the recipes with the correct BonusType to prevent unauthorized item duplication.

Additionally, related to this change, two more fixes were implemented. First, I corrected an issue where grinding ball were mistakenly installed into the machine when starting a process with a BonusType of NONE without any grinding ball installed. Second, I have updated the display of JEI to hide grinding balls for recipes with a BonusType of NONE.

Closes #586

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
I have performed a self-review of my own code.
I have commented my code in areas it may be challenging to understand.
I have made corresponding changes to the documentation.
My changes are ready for review from a contributor.

# Description In the SAG Mill's processing recipes, an incorrect `BonusType` was set, allowing for potential item duplication. To resolve this issue, I have updated the recipes with the correct `BonusType` to prevent unauthorized item duplication. Additionally, related to this change, two more fixes were implemented. First, I corrected an issue where grinding ball were mistakenly installed into the machine when starting a process with a `BonusType` of `NONE` without any grinding ball installed. Second, I have updated the display of JEI to hide grinding balls for recipes with a `BonusType` of `NONE`. Closes #586  # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [x] I have performed a self-review of my own code. - [x] I have commented my code in areas it may be challenging to understand.  - [x] I have made corresponding changes to the documentation. - [x] My changes are ready for review from a contributor.

Rover656 (Migrated from github.com) approved these changes

2024-02-15 11:41:40 +00:00

Rover656 (Migrated from github.com) left a comment

This looks good to me. Thanks a lot for contributing!