Team-EnderIO/EnderIO

Fork 0

Create Void Seed to replace Experience Rod early game #638

Open

ferriarnus wants to merge 4 commits from ferriarnus/exp-changes into dev/1.21.1

ferriarnus commented

2024-03-23 14:14:45 +00:00

(Migrated from github.com)

Description

Currently, the Experience Rod does not fit the idea of a "skulk" theme we want to use for exp. We can however not simply lock the item behind skulk, as it is needed for both the exp vacuum and soul binder, making it essential for progression. To remedie this, I introduce a new item "Void Seeds". This item absorbs exp from exp orbs when in the offhand of a player (similar to mending). This stored exp can then be either drunk by the player to gain levels, or transferred to a tank to use in crafting. However, it is unable to take levels from the player. Once exp has been absorbed by the player, it is stuck on the player.

The Experience Rod and Obelisk will still exist and be able to take exp from the player. We just purely delay it a bit longer, as it is a powerful tool.

TODO

Texture.
Replace Experience Rod recipe (not this PR)
Sword upgrade (not this PR)

Breaking Changes

List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.

Checklist

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
I have made corresponding changes to the documentation.
My changes are ready for review from a contributor.

# Description Currently, the Experience Rod does not fit the idea of a "skulk" theme we want to use for exp. We can however not simply lock the item behind skulk, as it is needed for both the exp vacuum and soul binder, making it essential for progression. To remedie this, I introduce a new item "Void Seeds". This item absorbs exp from exp orbs when in the offhand of a player (similar to mending). This stored exp can then be either drunk by the player to gain levels, or transferred to a tank to use in crafting. However, it is **unable** to take levels **from** the player. Once exp has been absorbed by the player, it is stuck on the player. The Experience Rod and Obelisk will still exist and be able to take exp **from** the player. We just purely delay it a bit longer, as it is a powerful tool.  # TODO - [ ] Texture. - [ ] Replace Experience Rod recipe (not this PR) - [ ] Sword upgrade (not this PR) # Breaking Changes List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.  # Checklist - [ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [ ] I have made corresponding changes to the documentation. - [ ] My changes are ready for review from a contributor.

Rover656 commented

2024-03-23 23:15:18 +00:00

(Migrated from github.com)

I like this idea, nicely thought out :)

dphaldes commented

2024-04-22 07:12:17 +00:00

(Migrated from github.com)

Few gameplay notes:

The void seed only works in offhand and not main hand, which is not how mending works. (mending goes main hand, offhand and then armor slots (not important for us). Maybe even add curio slots after. )
Tbf, such an item such work anywhere in the inventory and not just main/offhand.
The void seed xp consumption is instant. There are no drinking ticks, and it is easy for the player to use by mistake. There needs to a small drinking cycle
I couldn't figure out how to add xp to a machine.

Few gameplay notes: 1. The void seed only works in offhand and not main hand, which is not how mending works. (mending goes main hand, offhand and then armor slots (not important for us). Maybe even add curio slots after. ) 2. Tbf, such an item such work anywhere in the inventory and not just main/offhand. 3. The void seed xp consumption is instant. There are no drinking ticks, and it is easy for the player to use by mistake. There needs to a small drinking cycle 4. I couldn't figure out how to add xp to a machine.

ferriarnus commented

2024-05-03 20:55:52 +00:00

(Migrated from github.com)

Few gameplay notes:

The void seed only works in offhand and not main hand, which is not how mending works. (mending goes main hand, offhand and then armor slots (not important for us). Maybe even add curio slots after. )

Tbf, such an item such work anywhere in the inventory and not just main/offhand.

The void seed xp consumption is instant. There are no drinking ticks, and it is easy for the player to use by mistake. There needs to a small drinking cycle

I couldn't figure out how to add xp to a machine.

That's fair, I did offhand assuming main would be killing the mob, but that may not be true.
Potentially, but I rather wouldn't search all inv slots for the item to tick it, for performance reasons.
Yeah that's a good shout, I'll look into that.
It should act as a fluid container, so adding it to a fluid tank should work?

> Few gameplay notes: > > 1. The void seed only works in offhand and not main hand, which is not how mending works. (mending goes main hand, offhand and then armor slots (not important for us). Maybe even add curio slots after. ) > 2. Tbf, such an item such work anywhere in the inventory and not just main/offhand. > 3. The void seed xp consumption is instant. There are no drinking ticks, and it is easy for the player to use by mistake. There needs to a small drinking cycle > 4. I couldn't figure out how to add xp to a machine. 1) That's fair, I did offhand assuming main would be killing the mob, but that may not be true. 2) Potentially, but I rather wouldn't search all inv slots for the item to tick it, for performance reasons. 3) Yeah that's a good shout, I'll look into that. 4) It should act as a fluid container, so adding it to a fluid tank should work?

Rover656 commented

2024-07-03 18:35:53 +00:00

(Migrated from github.com)

Where are we with this PR?

ferriarnus commented

2024-07-03 19:54:39 +00:00

(Migrated from github.com)

Besides maybe a proper texture, I think this is done if we agree with the idea

Rover656 commented

2024-07-07 01:49:08 +00:00

(Migrated from github.com)

I'd like to think about this more, happy to help migrate this after the reorganisation

This pull request has changes conflicting with the target branch.

enderio-base/src/generated/resources/assets/enderio/lang/en_us.json
enderio-base/src/main/java/com/enderio/base/common/init/EIOItems.java
enderio-base/src/main/java/com/enderio/base/data/recipe/ItemRecipeProvider.java
enderio-machines/src/main/java/com/enderio/machines/data/recipes/MachineRecipeProvider.java
enderio/src/generated/resources/assets/enderio/models/item/void_seed.json
enderio/src/generated/resources/data/enderio/advancement/recipes/tools/void_seed.json
enderio/src/generated/resources/data/enderio/recipe/void_seed.json
enderio/src/generated/resources/data/enderio/recipe/xp_vacuum.json
enderio/src/main/java/com/enderio/enderio/content/tools/VoidSeedItem.java
enderio/src/main/resources/assets/enderio/textures/item/void_seed.png

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin ferriarnus/exp-changes:ferriarnus/exp-changes

git switch ferriarnus/exp-changes

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch dev/1.21.1

git merge --no-ff ferriarnus/exp-changes

git switch ferriarnus/exp-changes

git rebase dev/1.21.1

git switch dev/1.21.1

git merge --ff-only ferriarnus/exp-changes

git switch ferriarnus/exp-changes

git rebase dev/1.21.1

git switch dev/1.21.1

git merge --no-ff ferriarnus/exp-changes

git switch dev/1.21.1

git merge --squash ferriarnus/exp-changes