Fix fluid handler not properly filtering #639

Merged

ferriarnus merged 1 commit from fluid-fixes into dev/1.20.4

2024-03-29 16:42:48 +00:00

ferriarnus commented

2024-03-23 19:51:24 +00:00

(Migrated from github.com)

Description

Seems that during the port + tank rewrite I made some mistakes with regards to tank filtering. Have a look if this fixes everything I say it does, and if there are no more case I've missed.

Fixes

Not checking the resource in drain.
Only checking the filter, not the current fluid for validity.
Not checking the filter on fill.
Pushing/pulling fluids without stack sensitive calls.

TODO

If this is a draft, populate this with remaining tasks. Otherwise, remove this section.

Breaking Changes

List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.

Checklist

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
I have made corresponding changes to the documentation.
My changes are ready for review from a contributor.

# Description Seems that during the port + tank rewrite I made some mistakes with regards to tank filtering. Have a look if this fixes everything I say it does, and if there are no more case I've missed. Fixes - Not checking the resource in drain. - Only checking the filter, not the current fluid for validity. - Not checking the filter on fill. - Pushing/pulling fluids without stack sensitive calls.  # TODO - [ ] If this is a draft, populate this with remaining tasks. Otherwise, remove this section. # Breaking Changes List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.  # Checklist - [ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [ ] I have made corresponding changes to the documentation. - [ ] My changes are ready for review from a contributor.