[1.20.1] Item Filters #649

Closed

LetterN wants to merge 5 commits from filters-how into dev/1.20.1

LetterN commented

2024-04-10 07:17:10 +00:00

(Migrated from github.com)

Description

readd filters but slightly different

BASIC_ITEM_FILTER 9x2 with basic nbt strictness support
BIG_ITEM_FILTER 9x4 same as it's basic counterpart

** THIS DOESN'T FIX CONDUITS NOT SAVING ITEMS IN THE FILTER SLOT **

other ideas: literal tag item renamed on anvil for itemtags (not consumed, only copied -> converted to )

TODO

filter UI
(optional, currently looking how to impl this) make the conduit ui have the tooltip back and the slot icons

Checklist

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
I have made corresponding changes to the documentation.
My changes are ready for review from a contributor.

## Description readd filters but slightly different - `BASIC_ITEM_FILTER` 9x2 with basic nbt strictness support - `BIG_ITEM_FILTER` 9x4 same as it's basic counterpart ** THIS DOESN'T FIX CONDUITS NOT SAVING ITEMS IN THE FILTER SLOT ** other ideas: literal tag item renamed on anvil for itemtags (not consumed, only copied -> converted to <data>)  ## TODO - [x] filter UI - [ ] (optional, currently looking how to impl this) make the conduit ui have the tooltip back and the slot icons  ## Checklist - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [x] I have made corresponding changes to the documentation. - [ ] My changes are ready for review from a contributor.

Leclowndu93150 commented

2024-04-10 08:44:55 +00:00

(Migrated from github.com)

don't forget fluid ones: P

ferriarnus commented

2024-05-15 12:54:54 +00:00

(Migrated from github.com)

So I realise I didn't comment here on the PR itself. I have some issue with thus PR that need to be adressed before we will consider merging it: The first one is that it targets 1.20.1. We have moved our active dev version to 1.20.6 since it had nice additions that make our lives a lot easier. This means that before we will merge ir in 1.20.1, it needs to be merged upstream. Secondly, I have some issues with how the conduit filter item is retrieved. This should be done on the API level instead. Conduits are a sensitive part if the code that we need to be carefull with, as one small mistake can destroy performance. Another issue is the filters themselves: they need to be in the base enderio module as other machines also need them, and ideally they use some ´Predicate´ based capability. That would make inter mod compat also possible. I have started a private branch with a proof of concept conduit filter impl already. If you are interested I will open it up so you can continue the work on that one (and backport it later).

👍 1

Leclowndu93150 commented

2024-05-15 15:08:30 +00:00

(Migrated from github.com)

The only reason they made it for 1.20.1 is because they need it for their modpack

👎 1