Conduit Overhaul - API, Upgrades and Filters #660
No reviewers
Labels
No labels
Area-Assets
Area-Backend
Area-Conduits
Area-Datapacks
Area-Lang
Area-Mod Compat
Area-Parity
Area-Rendering
Good first issue
MC-1.19.2
MC-1.20.1
MC-1.20.4
MC-1.20.6
MC-1.21
MC-1.21.1
Modtoberfest
P-0-High
P-1-Medium
P-2-Low
Status-Awaiting Response
Status-Behind-Flag
Status-Blocked
Status-Cannot Reproduce
Status-Duplicate
Status-Help Wanted
Status-Incomplete Report
Status-Invalid
Status-Needs LTS Backport
Status-Needs Updating
Status-Stale
Status-To Implement
Status-Triage
Status-Wontfix
Status-Wontmerge
Type-Backport
Type-Bug
Type-Documentation
Type-Enhancement
Type-Question
Type-RFC
Type-Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Team-EnderIO/EnderIO#660
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/conduit-filters"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
Rebased variant of #659.
This PR will add item & fluid filters and upgrades, as well as introduce some general API improvements to conduits and properly fit them into 1.20.6.
Thanks @ferriarnus for the bulk of the work; I've just come in to tidy up conduits and get this up to 1.20.6.
TODO
Breaking Changes
List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.
This will break all of conduit APIs - but this is fine because 1.20.6 isn't released yet.
More care will be taken to minimize the API modifications when backporting to 1.20.1.
NOTE: This will also break the conduit saved data NBT format. Saves before this PR will not load; luckily, 7.0 hasn't released yet so we can make this change :)
Checklist
@ -0,0 +1,105 @@package com.enderio.api.network;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck> reported by reviewdog 🐶
Missing package-info.java file.
@ -0,0 +1,87 @@package com.enderio.base.client.gui.screen;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.MissingSwitchDefaultCheck> reported by reviewdog 🐶
switch without "default" clause.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.InnerAssignmentCheck> reported by reviewdog 🐶
Inner assignments should be avoided.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.InnerAssignmentCheck> reported by reviewdog 🐶
Inner assignments should be avoided.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.InnerAssignmentCheck> reported by reviewdog 🐶
Inner assignments should be avoided.
@ -0,0 +1,64 @@package com.enderio.base.client.gui.screen;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.MissingSwitchDefaultCheck> reported by reviewdog 🐶
switch without "default" clause.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.InnerAssignmentCheck> reported by reviewdog 🐶
Inner assignments should be avoided.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.InnerAssignmentCheck> reported by reviewdog 🐶
Inner assignments should be avoided.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.InnerAssignmentCheck> reported by reviewdog 🐶
Inner assignments should be avoided.
@ -0,0 +1,55 @@package com.enderio.base.common.item.filter;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck> reported by reviewdog 🐶
Missing package-info.java file.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck> reported by reviewdog 🐶
Missing package-info.java file.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck> reported by reviewdog 🐶
Missing package-info.java file.
@ -0,0 +1,164 @@package com.enderio.core.common.capability;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
@ -0,0 +1,157 @@package com.enderio.core.common.capability;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
@ -0,0 +1,550 @@package com.enderio.conduits.common.conduit;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.modifier.RedundantModifierCheck> reported by reviewdog 🐶
Redundant 'public' modifier.
@ -0,0 +1,4 @@package com.enderio.api.conduit.upgrade;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck> reported by reviewdog 🐶
Missing package-info.java file.
@ -0,0 +1,8 @@package com.enderio.api.filter;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck> reported by reviewdog 🐶
Missing package-info.java file.
@ -0,0 +1,39 @@package com.enderio.conduits.data.tags;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck> reported by reviewdog 🐶
Missing package-info.java file.
@ -0,0 +1,33 @@package com.enderio.api.conduit.model;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck> reported by reviewdog 🐶
Missing package-info.java file.
@ -0,0 +1,65 @@package com.enderio.conduits.client.model.conduit.modifier;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck> reported by reviewdog 🐶
Missing package-info.java file.
@ -0,0 +1,29 @@package com.enderio.api.conduit.screen;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck> reported by reviewdog 🐶
Missing package-info.java file.
@ -0,0 +1,31 @@package com.enderio.conduits.client.gui.conduit;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck> reported by reviewdog 🐶
Missing package-info.java file.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.MissingSwitchDefaultCheck> reported by reviewdog 🐶
switch without "default" clause.
@ -0,0 +1,68 @@package com.enderio.conduits.common.network;🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.ConstantNameCheck> reported by reviewdog 🐶
Name 'instance' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
It's time for final checks and review :)