Create RS2 Conduits #750

Merged
ferriarnus merged 8 commits from rs2-conduits into dev/1.21 2024-08-21 16:20:29 +00:00
ferriarnus commented 2024-07-19 15:56:43 +00:00 (Migrated from github.com)

Description

It seems to work now, though in some case it visually doesn't update.

TODO

  • codec
  • connection logic
  • textures

Breaking Changes

List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.
# Description It seems to work now, though in some case it visually doesn't update. <!-- If you're submitting a Draft PR, consider providing a TODO list using checkboxes --> # TODO - [x] codec - [x] connection logic - [x] textures # Breaking Changes List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics. <!-- For drafts, fill this in as you go; if you are leaving draft, make sure these are all complete. --> # Checklist - [ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [ ] I have made corresponding changes to the documentation. - [ ] My changes are ready for review from a contributor. <!-- Thanks to: https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ for the building blocks of this template -->
Rover656 (Migrated from github.com) reviewed 2024-08-21 11:05:42 +00:00
Rover656 (Migrated from github.com) requested changes 2024-08-21 11:56:14 +00:00
Rover656 (Migrated from github.com) left a comment

Looks good and tested as working. Just a couple of tweaks before we can merge this.
Thank you!

Looks good and tested as working. Just a couple of tweaks before we can merge this. Thank you!
Rover656 (Migrated from github.com) commented 2024-08-21 11:55:04 +00:00

Was this necessary? The dependency should be transient by including eio conduits.

Was this necessary? The dependency should be transient by including eio conduits.
Rover656 (Migrated from github.com) commented 2024-08-21 11:55:24 +00:00

Can we call this RefinedStorageModule for consistency?

Can we call this RefinedStorageModule for consistency?
Rover656 (Migrated from github.com) approved these changes 2024-08-21 16:20:28 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#750
No description provided.