Fixed a number of fluid and filter bugs #815

Merged

Rover656 merged 5 commits from fix/fluids-and-filters into lts/1.20.1

2024-09-26 22:10:21 +00:00

Rover656 commented

2024-09-26 20:32:09 +00:00

(Migrated from github.com)

Description

Fixes #770
Fixes #774
Fixes #768
Fixes #811
Fixes #769

Some of these changes will need to be ported back up to 1.21.

Breaking Changes

None

Checklist

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
I have made corresponding changes to the documentation.
My changes are ready for review from a contributor.

# Description - Fixes #770 - Fixes #774 - Fixes #768 - Fixes #811 - Fixes #769 Some of these changes will need to be ported back up to 1.21. # Breaking Changes None  # Checklist - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [x] I have made corresponding changes to the documentation. - [x] My changes are ready for review from a contributor.

Rover656 commented

2024-09-26 20:36:23 +00:00

(Migrated from github.com)

Any player's wanting to test these changes can use the following build:
EnderIO-1.20.1-6.1-dev-fluids-and-filters-d2a46b2ae-all.zip

Any player's wanting to test these changes can use the following build: [EnderIO-1.20.1-6.1-dev-fluids-and-filters-d2a46b2ae-all.zip](https://github.com/user-attachments/files/17155755/EnderIO-1.20.1-6.1-dev-fluids-and-filters-d2a46b2ae-all.zip)

aevns commented

2024-09-26 21:33:51 +00:00

(Migrated from github.com)

it will not allow fluid insertion via bucket
it will not allow fluid insertion via pushing / pulling from adjacent fluid tanks
it will not allow fluid insertion via containers in the tank inventory / GUI

Tested it, and it certainly fixes issue #811. I ran into another issue while testing though: when a tank is set to push and then pushes fluids to other thanks, it will still be treated as full in many ways after being fully or partially emptied: - it will not allow fluid insertion via bucket - it will not allow fluid insertion via pushing / pulling from adjacent fluid tanks - it will not allow fluid insertion via containers in the tank inventory / GUI

👍 1

Rover656 commented

2024-09-26 21:54:13 +00:00

(Migrated from github.com)

Tested it, and it certainly fixes issue #811. I ran into another issue while testing though: when a tank is set to push and then pushes fluids to other thanks, it will still be treated as full in many ways after being fully or partially emptied:
* it will not allow fluid insertion via bucket

* it will not allow fluid insertion via pushing / pulling from adjacent fluid tanks

* it will not allow fluid insertion via containers in the tank inventory / GUI

Looks like I was setting the capacity of the item when updating the item wrongly - should work fine now if you delete that item and try again :)

EnderIO-1.20.1-6.1-dev-fluids-and-filters-70030713d-all.zip

> Tested it, and it certainly fixes issue #811. I ran into another issue while testing though: when a tank is set to push and then pushes fluids to other thanks, it will still be treated as full in many ways after being fully or partially emptied: > > * it will not allow fluid insertion via bucket > > * it will not allow fluid insertion via pushing / pulling from adjacent fluid tanks > > * it will not allow fluid insertion via containers in the tank inventory / GUI Looks like I was setting the capacity of the item when updating the item wrongly - should work fine now if you delete that item and try again :) [EnderIO-1.20.1-6.1-dev-fluids-and-filters-70030713d-all.zip](https://github.com/user-attachments/files/17156393/EnderIO-1.20.1-6.1-dev-fluids-and-filters-70030713d-all.zip)

👍 1

aevns commented

2024-09-26 22:03:28 +00:00

(Migrated from github.com)

Seems to work fine now :)

Rover656 commented

2024-09-26 22:09:15 +00:00

(Migrated from github.com)

Magic, thank you for testing!