Conduit Speed Reworks #822

Merged
Rover656 merged 6 commits from feat/faster-item-conduits into dev/1.21.1 2024-10-12 16:16:18 +00:00
Rover656 commented 2024-09-27 14:40:23 +00:00 (Migrated from github.com)

Description

Transfer Rate is the base speed of the item conduit with no upgrades, measured in Items per Cycle Tick Rate is the number of times in a tick the conduit "Cycles"

Adds two new conduit tiers: Enhanced Item Conduit and Ender Item Conduit. The maximum upgraded Ender Item Conduit can transfer 256 Items per Second.

Rates still could change, however I think this also gives a lot of power to pack devs who have specific requirements.

Still need to add textures and recipes.

The changed rates (with a temporary field not present in the PR which shows the maximum speed):

image
image
image

Feel free to make suggestions in this PR's comments.

TODO

  • Textures
  • Recipes
  • Possibly rename conduit transfer rate fields to make clear the unit?

Breaking Changes

This PR will break existing datapacks that add Item conduits. I don't imagine there are any, but in any case this will be a major version bump to 7.1.

Backport?

It should be possible to backport the speed improvements and additional tiers to 1.20.1, however it will not feature the configurability that 1.21.1 enjoys.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.
# Description Transfer Rate is the base speed of the item conduit with no upgrades, measured in Items per Cycle Tick Rate is the number of times in a tick the conduit "Cycles" Adds two new conduit tiers: Enhanced Item Conduit and Ender Item Conduit. The maximum upgraded Ender Item Conduit can transfer 256 Items per Second. Rates still could change, however I think this also gives a lot of power to pack devs who have specific requirements. Still need to add textures and recipes. The changed rates (with a temporary field not present in the PR which shows the maximum speed): ![image](https://github.com/user-attachments/assets/53712b7b-dd32-4039-8d61-710f604ac651) ![image](https://github.com/user-attachments/assets/9ace6b14-c0ae-45b7-b285-b7db03303cde) ![image](https://github.com/user-attachments/assets/2bc79b02-17da-4b81-9fbd-d78dd4e096c3) Feel free to make suggestions in this PR's comments. <!-- If you're submitting a Draft PR, consider providing a TODO list using checkboxes --> # TODO - [ ] Textures - [ ] Recipes - [ ] Possibly rename conduit transfer rate fields to make clear the unit? # Breaking Changes This PR will break existing datapacks that add Item conduits. I don't imagine there are any, but in any case this will be a major version bump to 7.1. # Backport? It should be possible to backport the speed improvements and additional tiers to 1.20.1, however it will not feature the configurability that 1.21.1 enjoys. <!-- For drafts, fill this in as you go; if you are leaving draft, make sure these are all complete. --> # Checklist - [ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [ ] I have made corresponding changes to the documentation. - [ ] My changes are ready for review from a contributor. <!-- Thanks to: https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ for the building blocks of this template -->
Rover656 commented 2024-10-03 18:51:42 +00:00 (Migrated from github.com)

Ignore the description, I ended up hijacking this branch to make conduit ticking changes and fixes to the tooltips.
Going to merge this now as its looking a lot more correct :)

Ignore the description, I ended up hijacking this branch to make conduit ticking changes and fixes to the tooltips. Going to merge this now as its looking a lot more correct :)
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Team-EnderIO/EnderIO#822
No description provided.