Make fluid conduits check all tanks #845

Closed

ferriarnus wants to merge 1 commit from fluid-conduit-iterate into dev/1.21.1

ferriarnus commented

2024-10-03 19:46:24 +00:00

(Migrated from github.com)

Description

Makes the fluid conduit iterate through all the fluids in the tank.

TODO

If this is a draft, populate this with remaining tasks. Otherwise, remove this section.

Breaking Changes

List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.

Checklist

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
I have made corresponding changes to the documentation.
My changes are ready for review from a contributor.

# Description Makes the fluid conduit iterate through all the fluids in the tank.  # TODO - [ ] If this is a draft, populate this with remaining tasks. Otherwise, remove this section. # Breaking Changes List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.  # Checklist - [ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [ ] I have made corresponding changes to the documentation. - [ ] My changes are ready for review from a contributor.

Rover656 commented

2024-10-05 22:51:47 +00:00

(Migrated from github.com)

That said - this PR also solves a problem of fluid conduits not working at all, when lockedFluid changed away from being Optional, that completely breaks the logic 😅

Might be worth more of a chat in Discord tomorrow, but honestly I think 840 might be a more "complete" solution to this after reading it over again. Thanks!

So I'm reading this over and wondering if we should actually do this similarly to the suggestion #840. This would still get stuck on the first tank in a fluid handler, even if it only had a small amount of fluid in the first tank. That said - this PR also solves a problem of fluid conduits not working at all, when lockedFluid changed away from being Optional, that completely breaks the logic 😅 Might be worth more of a chat in Discord tomorrow, but honestly I think 840 might be a more "complete" solution to this after reading it over again. Thanks!

Rover656 commented

2024-10-12 00:53:09 +00:00

(Migrated from github.com)

Okay I'm going to close this in favour of #840 after our discussion in Discord and thinking about this further. I'll port it up to 1.21 and fix the fluid problems at the same time :) Thanks for looking into this though!!