[1.21.1] Fix item loss during transfer in Item Conduits #899

Merged

DuraBrite merged 2 commits from fix/item-conduit-transfer-loss-dev-1.21.1 into dev/1.21.1

2024-12-09 23:12:43 +00:00

DuraBrite commented

2024-11-19 00:04:45 +00:00

(Migrated from github.com)

resolves issue where items were lost during transfer

Description

This PR fixes Issue #898, where items were lost during transfer via item conduits. The fix ensures synchronization between the extracted and inserted item amounts, preventing losses.

Breaking Changes

Adjusted logic in com/enderio/conduits/common/conduit/type/item/ItemConduitTicker.java:79 to account for notInserted values correctly.

Checklist

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
I have made corresponding changes to the documentation.
My changes are ready for review from a contributor.

- resolves issue where items were lost during transfer # Description This PR fixes [Issue #898](https://github.com/Team-EnderIO/EnderIO/issues/898), where items were lost during transfer via item conduits. The fix ensures synchronization between the extracted and inserted item amounts, preventing losses. # Breaking Changes Adjusted logic in `com/enderio/conduits/common/conduit/type/item/ItemConduitTicker.java:79` to account for `notInserted` values correctly. # Checklist - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [ ] I have made corresponding changes to the documentation. - [x] My changes are ready for review from a contributor.

Rover656 (Migrated from github.com) approved these changes

2024-12-09 23:03:17 +00:00

Rover656 (Migrated from github.com) left a comment

This looks sensible to me, thanks a lot!