[WIP] Add JEI support to EnderIO #95

2022-10-23T15:10:26Z

TagnumElite commented

2022-10-23 15:10:26 +00:00

(Migrated from github.com)

Description

Add JEI crafting categories for the Alloy Smelter, SAG Mill, Slice n Splice, Enchanter and Fire Crafting.

Fixes issue(s): # (issue)

Todo

Figure out how to get loot tables on the client
Figure out why FireCraftingCategory isn't alternating the blocks properly
Add anything else that might need to be added

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

# Description Add JEI crafting categories for the Alloy Smelter, SAG Mill, Slice n Splice, Enchanter and Fire Crafting. Fixes issue(s): # (issue) # Todo  - [ ] Figure out how to get loot tables on the client - [ ] Figure out why FireCraftingCategory isn't alternating the blocks properly - [ ] Add anything else that might need to be added # Checklist: - [ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation

Rover656 (Migrated from github.com) reviewed

2022-10-23 15:10:26 +00:00

src/machines/java/com/enderio/machines/integration/jei/EIOMachinesJeiPlugin.java

					
				@ -0,0 +81,4 @@

				    }

				    @Override

				    public void registerGuiHandlers(IGuiHandlerRegistration registration) {

Rover656 (Migrated from github.com) commented

2023-08-16 17:41:57 +00:00

It'd be a good idea to either use this or add a gui button for JEI to the screens

Rover656 commented

2022-10-23 15:12:00 +00:00

(Migrated from github.com)

I hate to say but this work has already been completed, I'd recommend discussion with us in Discord as we don't want to waste anyones time! I'll try get the branch that has these things published soon! Very sorry, but I'll leave this here for review and to influence any design decisions that may be important for the other implementation

TagnumElite commented

2022-10-23 15:23:11 +00:00

(Migrated from github.com)

Yeah, should've probably look harder and joined the discord earlier. Well I leave this alone for now.

Rover656 commented

2023-03-30 11:15:17 +00:00

(Migrated from github.com)

Superseded by #115, again you were Co Authored, so you have received credit for your work also! I essentially moved the soul vial integration from my implementation into another JEI plugin in base, then added the start of your fire crafting. Leaving this PR open for reference though as there's more work to do however it is blocked by some upstream changes.
Thanks again for your work!

Superseded by #115, again you were Co Authored, so you have received credit for your work also! I essentially moved the soul vial integration from my implementation into another JEI plugin in base, then added the start of your fire crafting. Leaving this PR open for reference though as there's more work to do however it is blocked by some upstream changes. Thanks again for your work!

👍 1

Rover656 commented

2024-05-03 21:01:14 +00:00

(Migrated from github.com)

I left this open in case I needed something, but I can't remember what that something is. For sake of clutter I will close this PR again - I want to thank you again for your work on this :)