multismelting #271

Merged

justliliandev merged 2 commits from fix/multismelting into dev/1.20.1

2023-07-11 07:25:49 +00:00

justliliandev commented

2023-07-09 18:05:12 +00:00

(Migrated from github.com)

Description

Allloy Smelter now pulls from multiple slots and starts from the last one

Fixes issue(s): #251

Checklist:

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

# Description Allloy Smelter now pulls from multiple slots and starts from the last one Fixes issue(s): #251 # Checklist: - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation

Rover656 (Migrated from github.com) approved these changes

2023-07-09 19:15:21 +00:00

Rover656 (Migrated from github.com) left a comment

Looks good, just a small question :)

src/machines/java/com/enderio/machines/common/recipe/AlloySmeltingRecipe.java

Rover656 (Migrated from github.com) commented

2023-07-09 19:14:18 +00:00

What was the reason for renaming this class?

justliliandev (Migrated from github.com) reviewed

2023-07-09 19:17:47 +00:00

src/machines/java/com/enderio/machines/common/recipe/AlloySmeltingRecipe.java

justliliandev (Migrated from github.com) commented

2023-07-09 19:17:47 +00:00

Duplicate Name. This would clash with the implements Container for the Sub Wrapper. Wait mvmd, I've moved that one, no it's not needed but to distinguish between the Container interface and the subwrapper

Rover656 (Migrated from github.com) reviewed

2023-07-09 19:19:16 +00:00

src/machines/java/com/enderio/machines/common/recipe/AlloySmeltingRecipe.java

Rover656 (Migrated from github.com) commented

2023-07-09 19:19:16 +00:00

Hmm, unsure if thats a good idea or not because we've called it "Container" for all of the other recipes. Maybe we could rename all the recipe containers "RecipeContainer" instead? Might be a good way to differ it from the interface

justliliandev (Migrated from github.com) reviewed

2023-07-10 21:59:33 +00:00

src/machines/java/com/enderio/machines/common/recipe/AlloySmeltingRecipe.java

justliliandev (Migrated from github.com) commented

2023-07-10 21:59:33 +00:00

I don't think it's necessary, it's just needed for the distinction between this specific wrapper and the subwrapper, I wouldn't change them all, as this only adds to the readability in this case