Conduit upgrade void #691

Merged

ferriarnus merged 1 commit from conduit-void into dev/1.21

2024-06-22 14:18:11 +00:00

ferriarnus commented

2024-06-20 17:19:04 +00:00

(Migrated from github.com)

Description

Currently, if adding a conduit fails it still runs the vanilla place code that consumes the stack. This is fixed here by returning "FAIL" when the conduit can not be added.

This methods use of optional is unclear to me, maybe a simple null is better?

fixes: #669

TODO

If this is a draft, populate this with remaining tasks. Otherwise, remove this section.

Breaking Changes

List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.

Checklist

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
I have made corresponding changes to the documentation.
My changes are ready for review from a contributor.

# Description Currently, if adding a conduit fails it still runs the vanilla place code that consumes the stack. This is fixed here by returning "FAIL" when the conduit can not be added. This methods use of optional is unclear to me, maybe a simple null is better? fixes: #669  # TODO - [ ] If this is a draft, populate this with remaining tasks. Otherwise, remove this section. # Breaking Changes List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.  # Checklist - [ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [ ] I have made corresponding changes to the documentation. - [ ] My changes are ready for review from a contributor.