Revert to old recipe manager mixin now KubeJS doesn't break it #974

Merged

Rover656 merged 1 commit from fix/recipe-manager-mixin into dev/1.21.1

2025-01-12 21:19:14 +00:00

Rover656 commented

2025-01-12 17:04:18 +00:00

(Migrated from github.com)

Description

This build has been tested in Enigmatica 10 (and resolves #972).

I would love some input from @rlnt as to whether this breaks Kube JS scripts for existing modpacks or not, as I'm unsure if this change will have an effect on the order of things, thanks!

Checklist

My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
I have made corresponding changes to the documentation.
My changes are ready for review from a contributor.

# Description This build has been tested in Enigmatica 10 (and resolves #972). I would love some input from @rlnt as to whether this breaks Kube JS scripts for existing modpacks or not, as I'm unsure if this change will have an effect on the order of things, thanks!  # Checklist - [x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you). - [x] I have made corresponding changes to the documentation. - [x] My changes are ready for review from a contributor.

rlnt commented

2025-01-12 21:14:26 +00:00

(Migrated from github.com)

The old implementation is a much cleaner approach and the preferred way in my opinion. However, since KubeJS uses a head inject into the RecipeManager#apply method, it won't be possible to remove inherited recipes via KubeJS anymore. This is an unfortunate side effect, but it's still the best solution. We were aware of that when changing the KubeJS event logic.

The only thing this will break in KubeJS scripts is anyone removing inherited recipes by IDs but I'd say this is fine.

The old implementation is a much cleaner approach and the preferred way in my opinion. However, since KubeJS uses a head inject into the `RecipeManager#apply` method, it won't be possible to remove inherited recipes via KubeJS anymore. This is an unfortunate side effect, but it's still the best solution. We were aware of that when changing the KubeJS event logic. The only thing this will break in KubeJS scripts is anyone removing inherited recipes by IDs but I'd say this is fine.

❤️ 1